Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue-882: maxBitrate in VIDEO_STREAMING capability is misread #883

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

shiniwat
Copy link
Contributor

@shiniwat shiniwat commented Oct 2, 2018

Fix issue-882: maxBitrate in VIDEO_STREAMING capability is misread

Fixes #882
This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

N/A

Summary

Fix the VideoStreamingParamters to handle maxBitrate correctly.

Changelog

Breaking Changes

N/A

Enhancements

N/A

Bug Fixes

#882

Tasks Remaining:

None

CLA

@codecov-io
Copy link

Codecov Report

Merging #883 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #883      +/-   ##
=============================================
- Coverage      42.06%   42.02%   -0.04%     
  Complexity      3284     3284              
=============================================
  Files            407      407              
  Lines          20190    20190              
  Branches        2194     2194              
=============================================
- Hits            8493     8485       -8     
- Misses         11295    11305      +10     
+ Partials         402      400       -2
Impacted Files Coverage Δ Complexity Δ
...link/streaming/video/VideoStreamingParameters.java 36.95% <0%> (ø) 7 <0> (ø) ⬇️
...smartdevicelink/encoder/VirtualDisplayEncoder.java 24.71% <0%> (-4.6%) 8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daaac59...09317db. Read the comment docs.

@joeygrover joeygrover merged commit be9355e into smartdevicelink:develop Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants