Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 739 choice vr optional #836

Merged
merged 9 commits into from
Aug 24, 2018
Merged

Feature/issue 739 choice vr optional #836

merged 9 commits into from
Aug 24, 2018

Conversation

BrettyWhite
Copy link
Contributor

Fixes #739

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

unit tests as they existed, no logic changed, just adding a constructor

Summary

  • deprecate old constructor
  • add new one without vr commands

CLA

@BrettyWhite BrettyWhite added the proposal Accepted SDL Evolution Proposal label Aug 16, 2018
@BrettyWhite BrettyWhite self-assigned this Aug 16, 2018
@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #836 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #836      +/-   ##
=============================================
- Coverage       43.8%   43.77%   -0.04%     
  Complexity      3038     3038              
=============================================
  Files            383      383              
  Lines          17795    17808      +13     
  Branches        1750     1751       +1     
=============================================
  Hits            7795     7795              
- Misses          9672     9685      +13     
  Partials         328      328
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/smartdevicelink/proxy/rpc/Choice.java 69.04% <0%> (-30.96%) 17 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae07b1a...f989954. Read the comment docs.

@joeygrover joeygrover merged commit 303247a into develop Aug 24, 2018
@joeygrover joeygrover deleted the feature/issue_739 branch August 24, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants