Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 751 Remote Control – Lights – More Names and Status Values #821

Closed
wants to merge 4 commits into from

Conversation

mrapitis
Copy link
Contributor

Fixes #751

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Added new unit tests and expanded existing ones

Summary

Added RPC's, structs, enums as defined in the Remote Control – Lights – More Names and Status Values proposal. Please note this should be merged after #624 as it has a dependency on it.

CLA

  • I have signed the CLA

@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #821 into develop will increase coverage by 0.91%.
The diff coverage is 92.36%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #821      +/-   ##
=============================================
+ Coverage      43.47%   44.38%   +0.91%     
- Complexity      3029     3181     +152     
=============================================
  Files            382      399      +17     
  Lines          17454    17799     +345     
  Branches        1734     1734              
=============================================
+ Hits            7588     7900     +312     
- Misses          9547     9580      +33     
  Partials         319      319
Impacted Files Coverage Δ Complexity Δ
...om/smartdevicelink/proxy/rpc/RadioControlData.java 100% <100%> (ø) 24 <2> (+2) ⬆️
...m/smartdevicelink/proxy/rpc/enums/DisplayMode.java 100% <100%> (ø) 2 <2> (?)
...com/smartdevicelink/proxy/rpc/StationIDNumber.java 100% <100%> (ø) 6 <6> (?)
...devicelink/proxy/rpc/enums/PrimaryAudioSource.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...devicelink/proxy/rpc/RadioControlCapabilities.java 100% <100%> (ø) 25 <2> (+2) ⬆️
...in/java/com/smartdevicelink/proxy/rpc/SisData.java 100% <100%> (ø) 12 <12> (?)
.../smartdevicelink/proxy/rpc/ClimateControlData.java 100% <100%> (ø) 30 <30> (+8) ⬆️
...om/smartdevicelink/proxy/rpc/enums/ModuleType.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...evicelink/proxy/rpc/RemoteControlCapabilities.java 100% <100%> (ø) 16 <6> (+6) ⬆️
.../smartdevicelink/proxy/rpc/enums/DistanceUnit.java 100% <100%> (ø) 2 <2> (?)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec84be...9dc3ca4. Read the comment docs.

@mrapitis
Copy link
Contributor Author

Closing in favor of #712

@mrapitis mrapitis closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants