Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 739 make choice VR optional #801

Closed
wants to merge 2 commits into from

Conversation

BrettyWhite
Copy link
Contributor

@BrettyWhite BrettyWhite commented Jun 28, 2018

Fixes #739

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

ran unit tests

Summary

  • Changed required parameter to optional, Deprecate old constructor

CLA

@BrettyWhite BrettyWhite added the proposal Accepted SDL Evolution Proposal label Jun 28, 2018
@BrettyWhite BrettyWhite self-assigned this Jun 28, 2018
@BrettyWhite BrettyWhite deleted the feature/issue_739 branch June 28, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant