Implementing new ElectronicParkBrakeStatus #797

askirk · 2018-06-22T17:23:00Z

Fixes #632

This PR is [ready] for review.

Risk

This PR makes [minor] API changes.

Testing Plan

Unit tests were updated to cover new code changes.

Summary

adding new enum
adding additional VehicleDataType
adding field in Subscribe and Unsubscribe Vehicle Data Request & Response
adding field in GetVehicleData Request & Response
adding field in OnVehicleData notification
adding corresponding sections to unit tests to cover new code

Changelog

Enhancements

New vehicle data available electronicParkBrakeStatus

CLA

I have signed the CLA

- adding new enum - adding additional VehicleDataType - adding field in Subscribe and Unsubscribe Vehicle Data Request & Response - adding field in GetVehicleData Request & Response - adding field in OnVehicleData notification - adding corresponding sections to unit tests to cover new code

codecov-io · 2018-06-22T17:37:34Z

Codecov Report

Merging #797 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             develop     #797     +/-   ##
============================================
+ Coverage      42.74%   42.85%   +0.1%     
- Complexity      2900     2916     +16     
============================================
  Files            369      370      +1     
  Lines          17187    17218     +31     
  Branches        1732     1732             
============================================
+ Hits            7347     7378     +31     
  Misses          9523     9523             
  Partials         317      317

Impacted Files	Coverage Δ	Complexity Δ
...a/com/smartdevicelink/proxy/rpc/OnVehicleData.java	`95.09% <100%> (+0.14%)`	`59 <2> (+2)`	⬆️
...ink/proxy/rpc/enums/ElectronicParkBrakeStatus.java	`100% <100%> (ø)`	`2 <2> (?)`
...martdevicelink/proxy/rpc/SubscribeVehicleData.java	`98.88% <100%> (+0.03%)`	`59 <2> (+2)`	⬆️
...rtdevicelink/proxy/rpc/GetVehicleDataResponse.java	`96.22% <100%> (+0.1%)`	`60 <2> (+2)`	⬆️
...artdevicelink/proxy/rpc/enums/VehicleDataType.java	`100% <100%> (ø)`	`2 <0> (ø)`	⬇️
...link/proxy/rpc/UnsubscribeVehicleDataResponse.java	`96.84% <100%> (+0.1%)`	`59 <2> (+2)`	⬆️
.../com/smartdevicelink/proxy/rpc/GetVehicleData.java	`98.92% <100%> (+0.03%)`	`61 <2> (+2)`	⬆️
...rtdevicelink/proxy/rpc/UnsubscribeVehicleData.java	`98.88% <100%> (+0.03%)`	`59 <2> (+2)`	⬆️
...celink/proxy/rpc/SubscribeVehicleDataResponse.java	`96.84% <100%> (+0.1%)`	`59 <2> (+2)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9cf35...5ab611d. Read the comment docs.

BrettyWhite · 2018-06-27T15:15:15Z

.../src/androidTest/java/com/smartdevicelink/test/rpc/enums/ElectronicParkBrakeStatusTests.java

+	}
+
+	/**
+	 * Verifies the possible enum values of WiperStatus.


Not WiperStatus

BrettyWhite · 2018-06-27T15:17:24Z

sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/requests/GetVehicleDataTests.java

@@ -162,6 +165,7 @@ public void testRpcValues () {
        assertNull(Test.NULL, msg.getEmergencyEvent());
        assertNull(Test.NULL, msg.getClusterModeStatus());
        assertNull(Test.NULL, msg.getMyKey());
+	    assertNull(Test.NULL, msg.getElectronicParkBrakeStatus());


Not sure how picky we want to be with tabs/spaces but there are a lot of lines in this PR that dont line up

# Conflicts: # sdl_android/src/androidTest/assets/json/GetVehicleData.json # sdl_android/src/androidTest/assets/json/SubscribeVehicleData.json # sdl_android/src/androidTest/assets/json/UnsubscribeVehicleData.json # sdl_android/src/androidTest/java/com/smartdevicelink/test/VehicleDataHelper.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/enums/VehicleDataTypeTests.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/notifications/OnVehicleDataTests.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/requests/GetVehicleDataTests.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/requests/SubscribeVehicleDataTests.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/requests/UnsubscribeVehicleDataTests.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/responses/GetVehicleDataResponseTests.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/responses/SubscribeVehicleDataResponseTest.java # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/responses/UnsubscribeVehicleDataResponseTest.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/GetVehicleData.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/GetVehicleDataResponse.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/OnVehicleData.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleData.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleDataResponse.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleData.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleDataResponse.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/enums/VehicleDataType.java

joeygrover · 2018-07-10T21:34:13Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/GetVehicleData.java

@@ -474,4 +475,12 @@ public Boolean getFuelRange() {
     * @return a Boolean value.
     */
    public Boolean getTurnSignal() { return getBoolean(KEY_TURN_SIGNAL); }
+
+    public void setElectronicParkBrakeStatus(Boolean electronicParkBrakeStatus){


Please add javadoc

joeygrover · 2018-07-10T21:34:19Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/GetVehicleData.java

+        setParameters(KEY_ELECTRONIC_PARK_BRAKE_STATUS, electronicParkBrakeStatus);
+    }
+
+    public Boolean getElectronicParkBrakeStatus(){


Please add javadoc

joeygrover · 2018-07-10T21:34:33Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/GetVehicleDataResponse.java

@@ -295,4 +297,11 @@ public void setTurnSignal(TurnSignal turnSignal) {
    public TurnSignal getTurnSignal() {
        return (TurnSignal) getObject(TurnSignal.class, KEY_TURN_SIGNAL);
    }
+
+    public void setElectronicParkBrakeStatus(ElectronicParkBrakeStatus electronicParkBrakeStatus){


Please add javadoc

joeygrover · 2018-07-10T21:34:38Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/GetVehicleDataResponse.java

+    public void setElectronicParkBrakeStatus(ElectronicParkBrakeStatus electronicParkBrakeStatus){
+        setParameters(KEY_ELECTRONIC_PARK_BRAKE_STATUS, electronicParkBrakeStatus);
+    }
+    public ElectronicParkBrakeStatus getElectronicParkBrakeStatus(){


Please add javadoc

joeygrover · 2018-07-10T21:34:51Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/OnVehicleData.java

@@ -510,4 +512,11 @@ public void setTurnSignal(TurnSignal turnSignal) {
    public TurnSignal getTurnSignal() {
        return (TurnSignal) getObject(TurnSignal.class, KEY_TURN_SIGNAL);
    }
+
+    public void setElectronicParkBrakeStatus(ElectronicParkBrakeStatus electronicParkBrakeStatus){


Please add javadoc

joeygrover · 2018-07-10T21:34:58Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/OnVehicleData.java

+    public void setElectronicParkBrakeStatus(ElectronicParkBrakeStatus electronicParkBrakeStatus){
+        setParameters(KEY_ELECTRONIC_PARK_BRAKE_STATUS, electronicParkBrakeStatus);
+    }
+    public ElectronicParkBrakeStatus getElectronicParkBrakeStatus(){


Please add javadoc

joeygrover · 2018-07-10T21:35:07Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleData.java

@@ -790,4 +791,11 @@ public Boolean getFuelRange() {
 	 * @return a Boolean value.
 	 */
 	public Boolean getTurnSignal() { return getBoolean(KEY_TURN_SIGNAL); }
+
+	public void setElectronicParkBrakeStatus(boolean electronicParkBrakeStatus){


Please add javadoc

joeygrover · 2018-07-10T21:35:14Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleData.java

+	public void setElectronicParkBrakeStatus(boolean electronicParkBrakeStatus){
+		setParameters(KEY_ELECTRONIC_PARK_BRAKE_STATUS, electronicParkBrakeStatus);
+	}
+	public Boolean getElectronicParkBrakeStatus(){


Please add javadoc

joeygrover · 2018-07-10T21:35:23Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleDataResponse.java

@@ -449,4 +450,11 @@ public void setTurnSignal(VehicleDataResult turnSignal) {
    public VehicleDataResult getTurnSignal() {
        return (VehicleDataResult) getObject(VehicleDataResult.class, KEY_TURN_SIGNAL);
    }
+
+    public void setElectronicParkBrakeStatus(VehicleDataResult electronicParkBrakeStatus){


Please add javadoc

joeygrover · 2018-07-10T21:35:28Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/SubscribeVehicleDataResponse.java

+    public void setElectronicParkBrakeStatus(VehicleDataResult electronicParkBrakeStatus){
+        setParameters(KEY_ELECTRONIC_PARK_BRAKE_STATUS, electronicParkBrakeStatus);
+    }
+    public VehicleDataResult getElectronicParkBrakeStatus(){


Please add javadoc

joeygrover · 2018-07-10T21:35:34Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleData.java

@@ -784,4 +785,11 @@ public Boolean getFuelRange() {
 	 * @return a Boolean value.
 	 */
 	public Boolean getTurnSignal() { return getBoolean(KEY_TURN_SIGNAL); }
+
+	public void setElectronicParkBrakeStatus(Boolean electronicParkBrakeStatus) {


Please add javadoc

joeygrover · 2018-07-10T21:35:38Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleData.java

+	public void setElectronicParkBrakeStatus(Boolean electronicParkBrakeStatus) {
+		setParameters(KEY_ELECTRONIC_PARK_BRAKE_STATUS, electronicParkBrakeStatus);
+	}
+	public Boolean getElectronicParkBrakeStatus() {


Please add javadoc

joeygrover · 2018-07-10T21:35:46Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleDataResponse.java

@@ -454,4 +455,11 @@ public void setTurnSignal(VehicleDataResult turnSignal) {
    public VehicleDataResult getTurnSignal() {
        return (VehicleDataResult) getObject(VehicleDataResult.class, KEY_TURN_SIGNAL);
    }
+
+    public void setElectronicParkBrakeStatus(VehicleDataResult electronicParkBrakeStatus){


Please add javadoc

joeygrover · 2018-07-10T21:35:50Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/UnsubscribeVehicleDataResponse.java

+    public void setElectronicParkBrakeStatus(VehicleDataResult electronicParkBrakeStatus){
+        setParameters(KEY_ELECTRONIC_PARK_BRAKE_STATUS, electronicParkBrakeStatus);
+    }
+    public VehicleDataResult getElectronicParkBrakeStatus(){


Please add javadoc

joeygrover · 2018-07-10T21:36:42Z

sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/enums/ElectronicParkBrakeStatus.java

+	/**
+	 * When system has a fault or is under maintenance.
+	 */
+	FAULT;


Please add a comma, an extra clear line, and move the semicolon underneath

askirk requested review from bilal-alsharifi, BrettyWhite and joeygrover June 22, 2018 17:23

BrettyWhite reviewed Jun 27, 2018

View reviewed changes

BrettyWhite added 3 commits July 10, 2018 15:13

manually fix merge conflicts for electronicPBS

276b616

fix improper javadoc

8e7070a

joeygrover reviewed Jul 10, 2018

View reviewed changes

adding javadocs

5ab611d

joeygrover approved these changes Jul 11, 2018

View reviewed changes

joeygrover merged commit 3f2a124 into develop Jul 11, 2018

joeygrover deleted the feature/issue_632 branch July 11, 2018 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing new ElectronicParkBrakeStatus #797

Implementing new ElectronicParkBrakeStatus #797

askirk commented Jun 22, 2018

codecov-io commented Jun 22, 2018 •

edited

Loading

BrettyWhite Jun 27, 2018

BrettyWhite Jun 27, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

joeygrover Jul 10, 2018

Implementing new ElectronicParkBrakeStatus #797

Implementing new ElectronicParkBrakeStatus #797

Conversation

askirk commented Jun 22, 2018

Risk

Testing Plan

Summary

Changelog

Enhancements

CLA

codecov-io commented Jun 22, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jun 22, 2018 •

edited

Loading