Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#739 Choice-VR optional #750

Closed
wants to merge 1 commit into from
Closed

#739 Choice-VR optional #750

wants to merge 1 commit into from

Conversation

EggeWang
Copy link

@EggeWang EggeWang commented May 3, 2018

Fixes #739

This PR is ready for review.

Risk

This PR makes no API changes.

Summary

This PR will allow app to create a choice without VrCommands.

CLA

@codecov-io
Copy link

Codecov Report

Merging #750 into develop will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #750      +/-   ##
=============================================
- Coverage      41.01%   40.95%   -0.07%     
  Complexity      2643     2643              
=============================================
  Files            362      362              
  Lines          15853    15857       +4     
  Branches        1695     1695              
=============================================
- Hits            6502     6494       -8     
- Misses          9044     9058      +14     
+ Partials         307      305       -2
Impacted Files Coverage Δ Complexity Δ
...n/java/com/smartdevicelink/proxy/SdlProxyBase.java 5.35% <0%> (-0.01%) 6 <0> (ø)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 24.71% <0%> (-4.6%) 8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f940b...3b0e229. Read the comment docs.

@EggeWang EggeWang closed this May 3, 2018
@EggeWang EggeWang deleted the feature_issue739 branch May 3, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants