Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 657, 783 - Remote Control - OnRCStatus notification #709

Merged
merged 6 commits into from
Jul 24, 2018

Conversation

mrapitis
Copy link
Contributor

@mrapitis mrapitis commented Mar 14, 2018

Fixes #657, #783

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Added new unit tests and expanded existing ones

Summary

Added RPC's, structs, enums as defined in the Remote Control OnRCStatus notification proposal.

CLA

  • I have signed the CLA

@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #709 into develop will decrease coverage by 0.04%.
The diff coverage is 42.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #709      +/-   ##
=============================================
- Coverage      43.43%   43.39%   -0.05%     
- Complexity      3018     3025       +7     
=============================================
  Files            380      381       +1     
  Lines          17415    17443      +28     
  Branches        1732     1734       +2     
=============================================
+ Hits            7565     7569       +4     
- Misses          9531     9557      +26     
+ Partials         319      317       -2
Impacted Files Coverage Δ Complexity Δ
...n/java/com/smartdevicelink/proxy/SdlProxyBase.java 4.75% <0%> (-0.02%) 6 <0> (ø)
...com/smartdevicelink/protocol/enums/FunctionID.java 89.89% <100%> (+0.1%) 8 <0> (ø) ⬇️
...java/com/smartdevicelink/proxy/rpc/OnRCStatus.java 64.7% <64.7%> (ø) 7 <7> (?)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 24.71% <0%> (-4.6%) 8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef10c5e...fc4233d. Read the comment docs.

@bilal-alsharifi
Copy link
Contributor

@mrapitis can we add allowed parameter to OnRCStatus as described in this proposal. It is a different proposal but it will make it easier for testing if we do them in one PR.

@mrapitis mrapitis changed the title Feature/issue 657- Remote Control - OnRCStatus notification Feature/issue 657, 783 - Remote Control - OnRCStatus notification Jul 12, 2018
@mrapitis
Copy link
Contributor Author

@bilal-alsharifi we have added the allowed parameter as described in #783 Can you please re-review when time permits? Thanks!

@joeygrover joeygrover merged commit 9682b37 into smartdevicelink:develop Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants