-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 657, 783 - Remote Control - OnRCStatus notification #709
Feature/issue 657, 783 - Remote Control - OnRCStatus notification #709
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #709 +/- ##
=============================================
- Coverage 43.43% 43.39% -0.05%
- Complexity 3018 3025 +7
=============================================
Files 380 381 +1
Lines 17415 17443 +28
Branches 1732 1734 +2
=============================================
+ Hits 7565 7569 +4
- Misses 9531 9557 +26
+ Partials 319 317 -2
Continue to review full report at Codecov.
|
b4bc2ec
to
e2aee65
Compare
@bilal-alsharifi we have added the allowed parameter as described in #783 Can you please re-review when time permits? Thanks! |
updated function id for onRCStatus
d40eda3
to
a8c6ff8
Compare
Fixes #657, #783
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Added new unit tests and expanded existing ones
Summary
Added RPC's, structs, enums as defined in the Remote Control OnRCStatus notification proposal.
CLA