Move router service message sending to its own thread #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r on a different thread
in the emitter.
JulianKast
approved these changes
Oct 25, 2023
This was referenced Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1850
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Previous author fixed broken test from changes made to the
TransportBrokerCore Tests
Tested connecting apps to Sync 3. I tested that with a single app and multiple apps.
Tested multiple disconnects/reconnect attempts.
Sync 3
Summary
This PR is based off #1851 with some refactoring.
Changelog
Bug Fixes
TransportBrokerCLA