Android 14 foreground service type required #1860

JulianKast · 2023-08-11T14:08:23Z

Fixes #1859

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

I have verified that I have not introduced new warnings in this PR (or explain why below)
I have run the unit tests with this PR
I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
I have tested Android

Unit Tests

Unit tests were run on the integration branch. CI check failed due to needing the app to target API 34.

Core Tests

Note: Before you install a second and third app, unplug the phone from the computer and switch the build variant before deploying the app to the phone otherwise Android Studio will kill the app.

Apps A, B and C.
Test 1:
Install App A
Accept BT permission
Install App B
Deny BT permission
Connect to TDK via AOA
Select App A to receive intent
Allow App B to connect when prompted
Observe: App B pass hosting the RS to app A and both apps connect.

Test 2:
Install App A
Deny BT permission
Install App B
Deny BT permission
Connect to TDK via AOA
Select App A to receive intent
Allow App B to connect when prompted
Observe App B passed hosting the RS to app A and both apps connect.

Test 3:
Install App A
Deny BT permission
Install App B
Deny BT permission
Install App C
Deny BT permission
Connect to TDK via AOA
Select App A to receive intent
Allow App C to connect when prompted
Allow App B to connect if you're prompted.(not 100%)
Observe App C passed hosting the RS to App B who passed to App A and Apps A and C are connected. App B may not connect.

Core version / branch / commit hash / module tested against: Sync 3
HMI name / version / branch / commit hash / module tested against: Sync 3

Summary

This pr adds the foreground service type of connectedDevice to our library. This is a requirement for Android 14.
With this addition, we are required to have either the Bluetooth Connect permission or call UsbManager.requestPermission() to have our service enter the foreground. if the connection is AOA and an app selected to host the RouterService does not have either permission, we will try to pass hosting the RouterService off to another app.

I also add the ability to be able to request the usb permission in SdlReceiver.onSdlEnabled in the event that

Changelog

Bug Fixes

Fixed the library to allow for it to target Android 14 and be able to enter the foreground

CLA

I have signed the CLA

…he RS

…r FGS type

…loy next RS if we don't have the permission

…f it has not been started at that point.

…ng SdlService, then request USB permission if we do not.

JulianKast · 2023-08-18T18:37:47Z

Unit test for Android currently fail due to needing to target API 34 which is in a different PR.

# Conflicts: # android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlService.java

joeygrover

Looks like the other PRs need to be finished and merged into develop, then develop back into this branch to test more properly. During the first review it seems like everything is working as it should, but will need to retest and more robustly post the rest of the fixes being merged.

android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterService.java

android/sdl_android/src/main/java/com/smartdevicelink/util/AndroidTools.java

android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterService.java

android/sdl_android/src/main/java/com/smartdevicelink/transport/UsbTransferProvider.java

android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlReceiver.java

…geUSBAccessoryReceived in RS

…droid Tools

…xt. Also make cachedContext a weak reference

# Conflicts: # android/sdl_android/src/main/java/com/smartdevicelink/util/AndroidTools.java

android/sdl_android/src/main/java/com/smartdevicelink/transport/UsbTransferProvider.java

joeygrover · 2023-11-28T19:02:34Z

android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlReceiver.java

+                    try {
+                        pendingIntent.send(context, 0, cachedIntent);
+                    } catch (PendingIntent.CanceledException e) {
+                        e.printStackTrace();
+                    }


There's currently no call to unregister this receiver so it will potentially leak. Changed the caught exception to a generic one as well in case something happens during unregistering.

Suggested change

try {

pendingIntent.send(context, 0, cachedIntent);

} catch (PendingIntent.CanceledException e) {

e.printStackTrace();

}

try {

pendingIntent.send(context, 0, cachedIntent);

context.unregisterReceiver(this);

} catch (Exception e) {

e.printStackTrace();

}

android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlReceiver.java

android/sdl_android/src/main/java/com/smartdevicelink/util/AndroidTools.java

android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlReceiver.java

android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterService.java

…to startSdlServiceIntent, remove unused import in SdlReceiver

…orid 14. Don't use get in For loop

…eneric one

joeygrover

Looks like one last missed change request from the previous review

joeygrover · 2023-11-29T16:19:38Z

android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlReceiver.java

+                    try {
+                        pendingIntentToStartService.send(context, 0, startSdlServiceIntent);
+                    } catch (PendingIntent.CanceledException e) {
+                        e.printStackTrace();
+                    }
+                }


This was missed from previous review.

Suggested change

try {

pendingIntentToStartService.send(context, 0, startSdlServiceIntent);

} catch (PendingIntent.CanceledException e) {

e.printStackTrace();

}

}

try {

pendingIntentToStartService.send(context, 0, startSdlServiceIntent);

context.unregisterReceiver(this);

} catch (Exception e) {

e.printStackTrace();

}

ah, looks like I made the this change in the wrong spot

…eiver

JulianKast added 14 commits August 10, 2023 15:05

Add FGS type connectedDevice to Manifest

c09d6d1

Add new UsbTransferProvider constructor

97f0fd2

Modify deployNextRouterService to take in a ParcelFileDescriptor in t…

773b61a

…he RS

Add ServicePermissionUtil to AndroidTools to check for permissions fo…

e5d61fc

…r FGS type

When the PFD is received in the RS, check for fgs permissions and dep…

6543c44

…loy next RS if we don't have the permission

update logic in UsbTransferProvider.bindService for starting the RS i…

9c3ad2a

…f it has not been started at that point.

add logic to SdlReceiver to check if we have permission before starti…

fe87adb

…ng SdlService, then request USB permission if we do not.

add checks for null

227ca75

remove debugging log

6e4c1c3

update unit test api level to api 34

aedfbb9

revert api level for unit test

b414113

update unit test jdk to 17

745719d

Revert test change in yml file

53ad1fc

Add try catch for entering foreground in SdlService for TCP connections

cf351c9

JulianKast added 4 commits August 23, 2023 10:11

remove extra space in RS

2d49e36

add spacing between methods

c31afdf

Add a targetApi to FOREGROUND_SERVICE_CONNECTED_DEVICE

ad5f699

move logic around and add java docs

0b6be0d

Base automatically changed from bugfix/issue_1852_update_gradle to develop October 19, 2023 15:00

JulianKast added 2 commits October 25, 2023 15:28

Merge branch 'develop' into bugfix/issue_1859_foreground_service_type

a452ff2

Merge branch 'develop' into bugfix/issue_1859_foreground_service_type

97a989f

# Conflicts: # android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlService.java

joeygrover requested changes Nov 6, 2023

View reviewed changes

JulianKast added 7 commits November 6, 2023 15:43

Refactor method name closeUSBAccessoryAttachmentActivity to acknowled…

647c5d9

…geUSBAccessoryReceived in RS

Remove inner class ServicePermissionUtil in AndroidTool

4314d9d

add null check to hasUsbAccessoryPermission and checkPermission in An…

bb4940e

…droid Tools

Make new UsbTransferProvider constructor protected

404725a

Remove reference to UsbTransferProvider in RS

2ccb87d

Clear out context in UsbTransferProvider.cancel()

177456f

Rename storedIntent and storedContext to cachedIntent and cachedConte…

2de8c9e

…xt. Also make cachedContext a weak reference

JulianKast added 6 commits November 7, 2023 14:06

Add javaDocs to AndroidTools.hasUsbAccessoryPermission

3275d18

Add JavaDocs to AndroidTools.checkPermission

5a3ff07

Add java doc to AndroidTools.hasForegroundServiceTypePermission

8b16303

Update javaDocs for deployNextRouterService in the RS

6b65585

Use context from mUsbReceiver instead of storing it in SdlReceiver

5bad185

Merge branch 'develop' into bugfix/issue_1859_foreground_service_type

762ffc9

# Conflicts: # android/sdl_android/src/main/java/com/smartdevicelink/util/AndroidTools.java

joeygrover requested changes Nov 28, 2023

View reviewed changes

JulianKast added 10 commits November 28, 2023 14:50

Rename PendingIntent to pendingIntentToStartService and cachedIntent …

3727e30

…to startSdlServiceIntent, remove unused import in SdlReceiver

Rename mUsbReceiver to usbPermissionReceiver

4c9833e

Clear out intents if there is no available USB device

c05011a

Use newly created method in AndroidTools to register receiver for And…

97b138e

…orid 14. Don't use get in For loop

Try to let UsbTransferProvider unbind before setting context to null

92905fa

Rename applicaitonContext to context, fix JavaDocs

8e9299a

Update startAltTransportTimer in RS

a12b93c

Unregister receiver to prevent leak, change exception catching to a g…

1d8e2cd

…eneric one

Remove whitespace

2114255

remove whitespace

4840581

joeygrover requested changes Nov 29, 2023

View reviewed changes

Unregister usbPermissionReceiver, revert unregister change for SdlRec…

8333284

…eiver

joeygrover approved these changes Nov 29, 2023

View reviewed changes

joeygrover merged commit 7ba7e31 into develop Nov 29, 2023
4 checks passed

joeygrover deleted the bugfix/issue_1859_foreground_service_type branch November 29, 2023 19:48

joeygrover mentioned this pull request Nov 29, 2023

Android 14 foreground service type required #1859

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android 14 foreground service type required #1860

Android 14 foreground service type required #1860

JulianKast commented Aug 11, 2023 •

edited

Loading

JulianKast commented Aug 18, 2023

joeygrover left a comment

joeygrover Nov 28, 2023

joeygrover left a comment

joeygrover Nov 29, 2023

JulianKast Nov 29, 2023

Android 14 foreground service type required #1860

Android 14 foreground service type required #1860

Conversation

JulianKast commented Aug 11, 2023 • edited Loading

Risk

Testing Plan

Unit Tests

Core Tests

Summary

Changelog

Bug Fixes

CLA

JulianKast commented Aug 18, 2023

joeygrover left a comment

Choose a reason for hiding this comment

joeygrover Nov 28, 2023

Choose a reason for hiding this comment

joeygrover left a comment

Choose a reason for hiding this comment

joeygrover Nov 29, 2023

Choose a reason for hiding this comment

JulianKast Nov 29, 2023

Choose a reason for hiding this comment

JulianKast commented Aug 11, 2023 •

edited

Loading