Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue #1842 - NPE in BaseTextAndGraphicsManager #1847

Merged
merged 13 commits into from
Jun 20, 2023

Conversation

JulianKast
Copy link
Contributor

@JulianKast JulianKast commented May 25, 2023

Fixes #1842

This PR is [ready] for review.

Risk

This PR makes [minor] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Core Tests

Tested general functionality of each manager touched to ensure they still function.
Then when into each manager and set the transactionQueue to null just before the null checks to ensure no crashes occurred, errors where logged, and callback listeners were triggered.

I also tested setting theFileManager transactionQueue to null while trying other managers that rely on it.

Tested Android Manticore v 2.11.0 and Sync 3
Tested JavaSE core 8.2.0 /sdl_hmi 5.8.0

Summary

This PR adds null checks to prevent NPE's with TaskMaster queues in the manager layers

Changelog

Bug Fixes
  • Fixes a reported NPE in BaseTextAndGraphicManager as well as preventing it throughout the manager layer

CLA

@joeygrover joeygrover changed the title Bugfix/issue 206 npe Bugfix/issue #1842 - NPE in BaseTextAndGraphicsManager May 25, 2023
@joeygrover joeygrover merged commit 19187e9 into develop Jun 20, 2023
@joeygrover joeygrover deleted the bugfix/issue_206_npe branch June 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants