Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending intent to ping intents #1844

Merged
merged 1 commit into from
May 30, 2023

Conversation

joeygrover
Copy link
Member

Fixes #1843

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

N/A

Core Tests

  • Installed app after RS was already connected and ensured that that app connected through SDL
  • Additionally, can test my killing HelloSdl while RS connected using a button on screen and adding the following logic:
        findViewById(R.id.helloSdlButton).setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                try {
                    android.os.Process.killProcess(android.os.Process.myPid());
                } catch (Exception e) {
                    e.printStackTrace();
                }
            }
        });

After this occurs the app will be restarted and connect through the pings sent out by the RS.

Core version: SYNC 3
HMI name: SYNC 3

Summary

Ensured the PendingIntent object was contained in the intents that were sent out during pings and transport status requests.

Changelog

Bug Fixes
  • PendingIntent to start apps' SdlService classes is now included in ping style broadcasts from SdlRouterService.
  • Increased SdlRouterService version number.

CLA

Removed cached pingIntent in favor of creating when needed to ensure pending intent was valid.
@JulianKast JulianKast merged commit e97757f into develop May 30, 2023
@JulianKast JulianKast deleted the bugfix/issue_1843_rs_missing_pi branch May 30, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants