Hot Fix for #1839. Adding fallback logic for starting router service #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this include an increment of the sdl_router_service_version_value value? I noticed the RS version of 17 in the graphic, but still 16 in the sdl.xml file (I can manually adjust to 17 for testing if needed). |
RS version will remain 16. So yes, 17 was for testing only and was manually adjusted. Referenced comment is to update the version in the gradle file before merging as a hotfix. |
mrapitis
approved these changes
Feb 8, 2023
JulianKast
requested changes
Feb 13, 2023
android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Julian Kast <[email protected]>
Library used for testing has been updated and our integration is broken because of it. There is no play to fix this, so removing the tests for now from actions.
JulianKast
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1839
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Java SE, and Java EEUnit Tests
None added for this PR as the changes are not unit testable.
Core Tests
Tested with a Gen3 Ford TDK
Cycled through testing different permission allocations and who would start and ultimately host the router service.
Summary
Essentially added a new logical assumption that all apps need to be targeting Android 12 at this point and therefore require the user granted Nearby Devices permission to receive Bluetooth connection intents. Therefore, if an older version of the library is installed that does not have the newer permission check logic prior to start the RS, if that app does not have the correct permission we can assume they will not be receiving the BT ACL connection intent and we can ignore the old legacy logic that it would have executed.
We also added a fallback call to start the newest router service in the case there was an older SDL enabled app on the device but their integration was incorrect.
Changelog
Hot Fix
Tasks Remaining:
CLA