Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloning the ImageRPC in the clone method for SdlArtwork #1821

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

JulianKast
Copy link
Contributor

@JulianKast JulianKast commented Jul 13, 2022

Fixes #1818

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

Github CI unit test

Core Tests

Tested on Manticore for SDL Core v8.1.0 for Android and Generic_HMI v0.12.0 with SDL Core v8.1.0 for JavaSE

Summary

When cloning a SdlArtwork instance, do not clone the imageRPC object with it. This prevents a case where the user changes the file name but the cached object does not update and the T&G manager uses that outdated information.

Changelog

Bug Fixes

CLA

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1821 (4f36392) into develop (e5d8537) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4f36392 differs from pull request most recent head b4b3945. Consider uploading reports for the commit b4b3945 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1821   +/-   ##
==========================================
  Coverage      54.05%   54.06%           
  Complexity      5531     5531           
==========================================
  Files            562      562           
  Lines          25809    25809           
  Branches        3395     3395           
==========================================
+ Hits           13952    13954    +2     
+ Misses         10585    10584    -1     
+ Partials        1272     1271    -1     
Impacted Files Coverage Δ
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 52.43% <0.00%> (+2.43%) ⬆️

@JulianKast JulianKast merged commit ccf0af9 into develop Jul 18, 2022
@JulianKast JulianKast deleted the bugfix/issue_1818 branch July 18, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants