Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Javadoc tables to match code #1820

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Update Javadoc tables to match code #1820

merged 1 commit into from
Jul 13, 2022

Conversation

noah-livio
Copy link
Contributor

@noah-livio noah-livio commented Jul 5, 2022

Fixes #1819

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR

Unit Tests

CI Tests

Core Tests

N/A

This PR only updates documentation

Summary

This PR updates the Javadoc tables listed in #1819 to align with code and spec. In cases where the code and spec do not match, the Javadoc was changed to match the code.

Changelog

Breaking Changes

N/A

Enhancements

N/A

Bug Fixes

CLA

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1820 (6e3519d) into develop (c1afd4f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6e3519d differs from pull request most recent head 7592b10. Consider uploading reports for the commit 7592b10 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1820      +/-   ##
=============================================
- Coverage      54.07%   54.06%   -0.02%     
+ Complexity      5534     5532       -2     
=============================================
  Files            562      562              
  Lines          25809    25809              
  Branches        3395     3395              
=============================================
- Hits           13956    13953       -3     
- Misses         10582    10584       +2     
- Partials        1271     1272       +1     
Impacted Files Coverage Δ
...java/com/smartdevicelink/proxy/rpc/AddCommand.java 100.00% <ø> (ø)
...java/com/smartdevicelink/proxy/rpc/AddSubMenu.java 100.00% <ø> (ø)
...com/smartdevicelink/proxy/rpc/BodyInformation.java 87.17% <ø> (ø)
...java/com/smartdevicelink/proxy/rpc/MenuParams.java 100.00% <ø> (ø)
...a/com/smartdevicelink/proxy/rpc/OnVehicleData.java 97.56% <ø> (ø)
.../main/java/com/smartdevicelink/proxy/rpc/Show.java 94.23% <ø> (ø)
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 50.00% <0.00%> (-1.22%) ⬇️
...ink/managers/screen/BaseTextAndGraphicManager.java 64.16% <0.00%> (-0.42%) ⬇️
...smartdevicelink/encoder/VirtualDisplayEncoder.java 45.36% <0.00%> (-0.34%) ⬇️

@noah-livio noah-livio marked this pull request as ready for review July 5, 2022 15:45
@JulianKast JulianKast merged commit e5d8537 into develop Jul 13, 2022
@JulianKast JulianKast deleted the fix/issue_1819 branch July 13, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants