Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 1805 #1806

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Bugfix/issue 1805 #1806

merged 1 commit into from
Apr 8, 2022

Conversation

noah-livio
Copy link
Contributor

Fixes #1805

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • [] I have run the unit tests with this PR - N/A
  • [] I have tested this PR against Core and verified behavior - N/A
  • I have tested Java SE

Unit Tests

None added but existing Java SE unit tests ran successfully

Core Tests

N/A - This is unrelated to any interaction with Core, this issue is only related to Gradle sync and build

Summary

Replaces testCompile with testImplementation in build.gradle for sdl_java_se

Changelog

Breaking Changes

None

Enhancements

None

Bug Fixes

CLA

@noah-livio noah-livio changed the base branch from master to 5.4.0_RC April 6, 2022 13:50
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1806 (f3b067d) into 5.4.0_RC (a624a06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             5.4.0_RC    #1806   +/-   ##
===========================================
  Coverage       54.05%   54.05%           
+ Complexity       5519     5518    -1     
===========================================
  Files             562      562           
  Lines           25723    25723           
  Branches         3372     3372           
===========================================
  Hits            13904    13904           
  Misses          10562    10562           
  Partials         1257     1257           
Impacted Files Coverage Δ
...nk/managers/audio/AudioDecoderCompatOperation.java 75.00% <0.00%> (-4.55%) ⬇️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 52.43% <0.00%> (+2.43%) ⬆️

@JulianKast JulianKast merged commit 1abdbf8 into 5.4.0_RC Apr 8, 2022
@JulianKast JulianKast deleted the bugfix/issue_1805 branch April 8, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdl_java_se uses deprecated testCompile in build.gradle
2 participants