-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some potential NPEs when session is null #1784
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1784 +/- ##
=============================================
- Coverage 54.39% 54.32% -0.07%
- Complexity 5516 5521 +5
=============================================
Files 562 562
Lines 25543 25590 +47
Branches 3328 3338 +10
=============================================
+ Hits 13893 13903 +10
- Misses 10391 10424 +33
- Partials 1259 1263 +4
|
Use SESSION_LOCK on synchronized blocks for session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, I think the only thing we need to add is we should wrap the initialization of session in a synchronized block as well. Can you also add a new comment or update the existing comment to better capture what changes this PR makes?
Sounds good, I'll make that change, and yeah I'll add a new comment to better reflect the current changes |
Fixes #1781 This PR is ready for review. RiskThis PR makes no API changes. Testing Plan
SummaryThis PR ensures all access to CLA
|
Fixes #1781
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
This PR fixes some potential NPEs that could happen if functions from
session
are called when the object is null.CLA