Cleanup/proposal sdl 0286 spacing #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1782 +/- ##
==========================================
Coverage 54.36% 54.37%
- Complexity 5509 5512 +3
==========================================
Files 562 562
Lines 25516 25515 -1
Branches 3319 3319
==========================================
+ Hits 13873 13874 +1
+ Misses 10384 10381 -3
- Partials 1259 1260 +1
|
RHenigan
suggested changes
Jan 28, 2022
...androidTest/java/com/smartdevicelink/test/rpc/notifications/OnAppCapabilityUpdatedTests.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/encoder/VirtualDisplayEncoder.java
Outdated
Show resolved
Hide resolved
RHenigan
reviewed
Jan 31, 2022
RHenigan
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses spacing and formatting from Proposal 0286
This PR is not ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
None, this pull request re-formats code without changing functionality
Core Tests
None, this pull request re-formats code without changing functionality
Summary
This PR changes indents and spacing for Java files in this project. Tabbed indents have been replaced with 4 spaces each. Spacing between arguments and keywords has been made consistent with the specifications in the proposal. Various newlines have been added or removed to make line spacing more consistent. Some levels of indentation have been corrected.
The following files have a diff with the branching commit in develop and the latest commit of this PR
Changelog
Breaking Changes
Enhancements
Bug Fixes
CLA