Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bluetooth adapter available check in RouterService for spp error notification #1766

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

JulianKast
Copy link
Contributor

Fixes #1661

This PR is [ready] for review.

Risk

This PR makes [no / minor / major] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Unit Tests

n/a

Core Tests

Run test 9.008 in the 5.3 SDL_Android Test Plan on sheet Multiplexing Security Tests.

Core version / branch / commit hash / module tested against: Synce 3.0
HMI name / version / branch / commit hash / module tested against: Sync 3.0

Summary

Added Bluetooth adapter available check to RouterService for spp error notification. This prevents a rare edge case where when having connected Bluetooth and USB, you keep turning on and off Bluetooth, you can get the spp error notification.

Changelog

Bug Fixes
  • [Added Bluetooth adapter available check to RouterService for spp error notification.

CLA

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1766 (03880c4) into develop (0bda034) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1766   +/-   ##
==========================================
  Coverage      54.37%   54.38%           
- Complexity      5498     5500    +2     
==========================================
  Files            562      562           
  Lines          25466    25466           
  Branches        3317     3317           
==========================================
+ Hits           13847    13849    +2     
+ Misses         10360    10358    -2     
  Partials        1259     1259           
Impacted Files Coverage Δ
...om/smartdevicelink/transport/SdlRouterService.java 11.09% <0.00%> (ø)
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (ø)
...nk/managers/audio/AudioDecoderCompatOperation.java 79.54% <0.00%> (+4.54%) ⬆️

@bilal-alsharifi bilal-alsharifi merged commit b2b1e59 into develop Dec 14, 2021
@bilal-alsharifi bilal-alsharifi deleted the bugfix/issue_1661 branch December 14, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants