Delete notification channel when possible #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the notification channel delete method call back into the router service. Some phones like the pixel 2 & 3 were only clearing the notificaiton 5-7 seconds after the service called stopForeground. Deleting the channel removes the notification instantly. We added a check to avoid a race condition in which the channel is deleted before the notifcation was actually shown.
Codecov Report
@@ Coverage Diff @@
## develop #1271 +/- ##
=============================================
- Coverage 47.07% 47.04% -0.03%
- Complexity 4343 4344 +1
=============================================
Files 482 482
Lines 23618 23632 +14
Branches 2714 2718 +4
=============================================
+ Hits 11117 11118 +1
- Misses 11837 11850 +13
Partials 664 664
|
|
Sweet, thanks for the fast turn around time! |
|
@bilal-alsharifi and @joeygrover I can come up to Livio and retest on my phone this Thursday if there's a way to get the latest build on it |
|
Thanks, @MichaelCrimando. I don't think there is a way to test the fix with the apps that you listed on the issue. The apps will need to update to get the fix. |
bilal-alsharifi
approved these changes
Feb 11, 2020
|
@MichaelCrimando This PR should fix the bug that you mentioned in issue #1267. Are you okay with merging it? |
|
@bilal-alsharifi I'm not a code reviewer, but I'll say yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1267 (partially)
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Core Tests
-None specifically. This revolves around bluetooth connections.
Summary
Added the notification channel delete method call back into the router service. Some phones like the pixel 2 & 3 were only clearing the notification 5-7 seconds after the service called stopForeground. Deleting the channel removes the notification instantly. We added a check to avoid a race condition in which the channel is deleted before the notification was actually shown.
Changelog
Bug Fixes
CLA