Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential NPEs in BaseMenuManager #1216

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Conversation

bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented Nov 12, 2019

Fixes #1215

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Try setting the menu to null and make sure the menu cells are getting cleared correctly without crashing the app:

sdlManager.getScreenManager().setMenu(null);

Summary

This PR fixes some potential NPEs in MenuManager when setting the menu to null

CLA

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #1216 into hotfix/4.10.1 will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             hotfix/4.10.1   #1216      +/-   ##
==================================================
+ Coverage             47.1%   47.1%   +<.01%     
- Complexity            4327    4328       +1     
==================================================
  Files                  481     481              
  Lines                23475   23479       +4     
  Branches              2683    2685       +2     
==================================================
+ Hits                 11057   11059       +2     
  Misses               11750   11750              
- Partials               668     670       +2
Impacted Files Coverage Δ Complexity Δ
...vicelink/managers/screen/menu/BaseMenuManager.java 45.12% <66.66%> (+0.03%) 91 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9377865...5dca01b. Read the comment docs.

@bilal-alsharifi bilal-alsharifi changed the base branch from develop to hotfix/4.10.1 November 13, 2019 20:17
@bilal-alsharifi bilal-alsharifi changed the title [WIP] Fix potential NPEs in BaseMenuManager Fix potential NPEs in BaseMenuManager Nov 14, 2019
@joeygrover joeygrover merged commit b144678 into hotfix/4.10.1 Nov 19, 2019
@joeygrover joeygrover deleted the bugfix/issue_1215 branch November 19, 2019 17:02
@bilal-alsharifi bilal-alsharifi mentioned this pull request Nov 19, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants