Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum improvements #118

Merged
merged 4 commits into from
Feb 23, 2015
Merged

Enum improvements #118

merged 4 commits into from
Feb 23, 2015

Conversation

mikeburke106
Copy link
Contributor

Signed-off-by: Mike Burke <[email protected]>
@mikeburke106 mikeburke106 self-assigned this Feb 18, 2015
@mikeburke106 mikeburke106 added this to the 3.2.2 milestone Feb 18, 2015
@mikeburke106
Copy link
Contributor Author

When this PR is merged, make sure to note #92 added valueOf() where it didn't exist before. Ensure VrCapabilities enum is updated with this change once #92 is merged as part of #113.

Mike Burke added 2 commits February 18, 2015 11:17
Signed-off-by: Mike Burke <[email protected]>
Signed-off-by: Mike Burke <[email protected]>
@mikeburke106 mikeburke106 added the REVIEW - offline The review will be discussed with the author offline label Feb 18, 2015
@mikeburke106
Copy link
Contributor Author

Trivial change is being marked for 3-day offline review. Anticipated merge date is 2/23 at 3pm.

@mikeburke106
Copy link
Contributor Author

Here are the results of the current unit tests for this PR.

Tests Run Test Passes (%) Test Failures (%) Test Errors (%)
1486 1476 (99%) 9 (<1%) 1 (<1%)

Of the 10 failed tests, 9 are related to #71, and 1 is related to #89. Both of these issues are slated to be merged by version 3.3.0, so all unit tests should be passed by March 1 or earlier.

@mikeburke106 mikeburke106 merged commit 3028ec4 into master Feb 23, 2015
@mikeburke106 mikeburke106 deleted the hotfix/enum_improvements branch February 23, 2015 21:56
@mikeburke106 mikeburke106 mentioned this pull request Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REVIEW - offline The review will be discussed with the author offline
Projects
None yet
1 participant