Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code analyzer issues #1179

Merged
merged 9 commits into from
Oct 2, 2019
Merged

Conversation

joeygrover
Copy link
Member

Fixes issues found in code analyzer

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • Run unit tests
  • Perform smoke tests

Summary

  • Fix potential NPEs
  • Optimize string and string builder usage
  • Optimize unnecessary reference creation
  • Fixed duplicate namespace in lockscreen layout
  • Added Android version checks for specific APIs and constant usage
Bug Fixes
  • Some of the issues found with the Android Studio code analyzer

CLA

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@1b57bdc). Click here to learn what that means.
The diff coverage is 5.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1179   +/-   ##
==========================================
  Coverage           ?   47.33%           
  Complexity         ?     4324           
==========================================
  Files              ?      481           
  Lines              ?    23359           
  Branches           ?     2658           
==========================================
  Hits               ?    11058           
  Misses             ?    11622           
  Partials           ?      679
Impacted Files Coverage Δ Complexity Δ
...va/com/smartdevicelink/transport/TCPTransport.java 0% <ø> (ø) 0 <0> (?)
...elink/transport/utl/ByteAraryMessageAssembler.java 44.11% <ø> (ø) 7 <0> (?)
...com/smartdevicelink/transport/TransportBroker.java 23.56% <0%> (ø) 20 <0> (?)
...ink/managers/permission/BasePermissionManager.java 73.04% <0%> (ø) 43 <0> (?)
...com/smartdevicelink/proxy/rpc/OnKeyboardInput.java 94.11% <0%> (ø) 8 <0> (?)
...tdevicelink/managers/video/VideoStreamManager.java 38.69% <0%> (ø) 14 <0> (?)
...smartdevicelink/proxy/rpc/DisplayCapabilities.java 75.51% <0%> (ø) 22 <0> (?)
...main/java/com/smartdevicelink/util/SdlAppInfo.java 37.5% <0%> (ø) 4 <0> (?)
...ink/managers/screen/BaseTextAndGraphicManager.java 49.32% <0%> (ø) 74 <0> (?)
...om/smartdevicelink/transport/SdlRouterService.java 11.79% <0%> (ø) 20 <0> (?)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b57bdc...31de199. Read the comment docs.

@BrettyWhite BrettyWhite merged commit 2ae92d9 into develop Oct 2, 2019
@BrettyWhite BrettyWhite deleted the feature/fix_code_analyzer_issues branch October 2, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants