-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TCP use new transport layers #1108
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1108 +/- ##
============================================
- Coverage 46.73% 45.5% -1.24%
- Complexity 4005 4693 +688
============================================
Files 453 470 +17
Lines 22141 27304 +5163
Branches 2513 3686 +1173
============================================
+ Hits 10348 12424 +2076
- Misses 11184 14119 +2935
- Partials 609 761 +152
Continue to review full report at Codecov.
|
android/sdl_android/src/main/java/com/smartdevicelink/protocol/SdlProtocol.java
Outdated
Show resolved
Hide resolved
this.requestedSecondaryTransports = null; | ||
this.requiresHighBandwidth =false; | ||
this.setTransportManager(new TCPTransportManager(config,transportEventListener)); | ||
this.requestedPrimaryTransports = Collections.singletonList(TransportType.TCP); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is in here twice
android/sdl_android/src/main/java/com/smartdevicelink/proxy/SdlProxyBase.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/transport/MultiplexTcpTransport.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/transport/TCPTransportManager.java
Outdated
Show resolved
Hide resolved
|
||
private static final String TAG = "TCPTransportManager"; | ||
|
||
TCPHandler tcpHandler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(unless we re-use it in resetSession()
in which case it could be private
android/sdl_android/src/main/java/com/smartdevicelink/transport/TCPTransportManager.java
Outdated
Show resolved
Hide resolved
@BrettyWhite Updates made based on comments, ready for review |
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Summary
Changelog
Enhancements
CLA