Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoStreamingManager should support multi-touch events #972

Closed
shiniwat opened this issue Feb 5, 2019 · 0 comments
Closed

VideoStreamingManager should support multi-touch events #972

shiniwat opened this issue Feb 5, 2019 · 0 comments

Comments

@shiniwat
Copy link
Contributor

shiniwat commented Feb 5, 2019

Bug Report

VideoStreamingManager currently does not support multi-touch events. Because OnTouchEvent RPC can notify multiple TouchEvents, VideoStreamingManager should support them.

Reproduction Steps
  1. Start VPM
  2. Made some multi-touch gesture.
  3. See how ON_TOUCH_EVENT notification listener in VideoStreamingManager handles the OnTouchEvent.
Expected Behavior

When OnTouchEvent in RPC notification contains multiple TouchEvents, VideoStreamingManager should handle all of them.

Observed Behavior

VideoStreamingManager handles single MotionEvent in this case.

OS & Version Information
  • Android Version: Android 9.0
  • SDL Android Version: sdl_android develop branch at 2facdae
  • Testing Against: SDL Core 4.5 + our own HMI.
Test Case, Sample Code, and / or Example App

Will make a PR later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bilal-alsharifi @shiniwat