Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in SdlBroadcastReceiver for uncaughtException handler #1845

Closed
joeygrover opened this issue May 25, 2023 · 1 comment
Closed

Typo in SdlBroadcastReceiver for uncaughtException handler #1845

joeygrover opened this issue May 25, 2023 · 1 comment
Labels
bug A defect in the library

Comments

@joeygrover
Copy link
Member

Bug Summary

The UncaughtException handler's if conditional currently has a typo of a misplaced ) that should be corrected. It affects the app's SdlService defined class and if it is handled by the libraries exception handler.

Reproduction Steps

Expected Behavior:
The handler is only triggered for Android's issue with starting foreground services in time.

Observed Behavior:
Incorrectly handles exceptions.

Which projects have you seen this bug on?

Android

Android Version(s)

No response

Android Device(s)

No response

sdl_java_suite Version

5.6.1

Testing Environment(s)

Any

Relevant log output

No response
@joeygrover joeygrover added the bug A defect in the library label May 25, 2023
joeygrover added a commit that referenced this issue May 25, 2023
@joeygrover
Fixes #1845
0e74122
@joeygrover joeygrover mentioned this issue May 25, 2023
Merged
5 tasks
JulianKast pushed a commit that referenced this issue May 30, 2023
@joeygrover
Fixes #1845 (#1846)
a37a7ea
@JulianKast
Copy link
Contributor

fixed with #1846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeygrover @JulianKast