Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deleting and setting identical voice commands #1676

Closed
theresalech opened this issue Apr 28, 2021 · 1 comment
Closed

Avoid deleting and setting identical voice commands #1676

theresalech opened this issue Apr 28, 2021 · 1 comment
Labels
bug A defect in the library

Comments

@theresalech
Copy link
Contributor

Bug Report

Currently, setting voice commands doesn't check for a diff of which voice commands are in the old and new lists. This results in a case where if voice commands are set like so:

voiceCommands = [command1, command2, command3]
voiceCommands = [command1, command2, command3, command 4]

What will happen is command1/2/3 will be set to the head unit, then command1/2/3 will be deleted from the head unit, then command1/2/3/4 will be set to the head unit.

Because voice commands can be so slow to process, we should diff and only set / delete what is necessary instead of taking an all-or-nothing approach.
@theresalech theresalech added the bug A defect in the library label Apr 28, 2021
@theresalech
Copy link
Contributor Author

Corresponding issues: iOS, JavaScript Suite

@JulianKast JulianKast mentioned this issue May 21, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bilal-alsharifi @theresalech