Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deleting and setting identical voice commands #1855

Closed
joeljfischer opened this issue Nov 19, 2020 · 0 comments
Closed

Avoid deleting and setting identical voice commands #1855

joeljfischer opened this issue Nov 19, 2020 · 0 comments
Labels
best practice Not a defect but something that should be improved anyway manager-screen Relating to the manager layer - screen managers

Comments

@joeljfischer
Copy link
Contributor

Bug Report

Currently, setting voice commands doesn't check for a diff of which voice commands are in the old and new lists. This results in a case where if voice commands are set like so:

voiceCommands = [command1, command2, command3]
voiceCommands = [command1, command2, command3, command 4]

What will happen is command1/2/3 will be set to the head unit, then command1/2/3 will be deleted from the head unit, then command1/2/3/4 will be set to the head unit.

Because voice commands can be so slow to process, we should diff and only set / delete what is necessary instead of taking an all-or-nothing approach.
@joeljfischer joeljfischer added the best practice Not a defect but something that should be improved anyway label Nov 19, 2020
@joeljfischer joeljfischer mentioned this issue Dec 1, 2020
Merged
4 tasks
@FrankElias77 FrankElias77 mentioned this issue Apr 1, 2021
Merged
4 tasks
@joeljfischer joeljfischer added the manager-screen Relating to the manager layer - screen managers label Apr 14, 2021
@theresalech theresalech mentioned this issue May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway manager-screen Relating to the manager layer - screen managers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeljfischer