Suspend and resume instead of restart video stream #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deo stream is ready and the app enters inactive state.
| @@ -434,6 +442,10 @@ - (void)didEnterStateVideoStreamReady { | |||
| } | |||
| } | |||
|
|
|||
| - (void)didEnterStateVideoStreamSuspended { | |||
There was a problem hiding this comment.
This method is unused
There was a problem hiding this comment.
True. I wasn‘t sure if the state methods must be implemented. I can remove it if it‘s not necessary.
There was a problem hiding this comment.
@NicoleYarroch I added the requested suspended notification to the method.
|
Every time the video comes to the foreground, a |
NicoleYarroch
suggested changes
May 30, 2018
NicoleYarroch
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979
This PR is ready for review.
Risk
This PR makes minor API changes:
shouldRestartVideoStreamis deprecated as not used anymore and can be deleted with the next major version.Testing Plan
There was a unit test if the app enters inactive state. The test was changed to match the new state.
Enhancements
CLA