Reset screen manager after disconnects #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added `stop` methods to the screen manager helpers to reset their stored properties on disconnection * Includes `screenManager`, `menuManager`, `softButtonManager`, `textAndGraphicsManager`, `voiceCommandManager` Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
NicoleYarroch
changed the title
joeljfischer
approved these changes
May 14, 2018
| @@ -52,7 +52,7 @@ A show describing the current text and images on the screen (not soft buttons, e | |||
| @property (strong, nonatomic, nullable) SDLDisplayCapabilities *displayCapabilities; | |||
| @property (strong, nonatomic, nullable) SDLHMILevel currentLevel; | |||
|
|
|||
| @property (strong, nonatomic) SDLArtwork *blankArtwork; | |||
| @property (strong, nonatomic, nullable) SDLArtwork *blankArtwork; | |||
There was a problem hiding this comment.
This shouldn't be reset to nil
There was a problem hiding this comment.
As mentioned in issue #953, I am getting a sdl_fileManager_fileDoesNotExistError for the blank artwork when I try to use it on reconnects. Setting the blank artwork to nil on disconnect was the only way I could fix the problem.
There was a problem hiding this comment.
In that case, put a comment explaining that where it's reset.
| @@ -589,7 +614,7 @@ - (BOOL)hasQueuedUpdate { | |||
| return (_hasQueuedUpdate || _queuedUpdateHandler != nil); | |||
| } | |||
|
|
|||
| - (SDLArtwork *)blankArtwork { | |||
| - (nullable SDLArtwork *)blankArtwork { | |||
There was a problem hiding this comment.
Shouldn't reset to nil
|
That was meant to be a "request changes" |
Signed-off-by: NicoleYarroch <[email protected]>
joeljfischer
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #952, #953
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Smoke tests
Summary
Fixes the
SDLScreenManagernot being reset when the app is reconnected to a head unit during a session. Menus, images, and buttons were not being set correctly on reconnects due the saved settings in theSDLScreenManager's sub managers.Changelog
Enhancements
SDLTextAndGraphicManager,SDLSoftButtonManager,SDLMenuManager, andSDLVoiceCommandManagerare now reset when the app disconnects from the head unit.Bug Fixes
nilcheck for a menu cell's handler before it is called.Tasks Remaining
CLA