Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to stop audio streaming at HMI level none and background (resubmission of #804) #871

Conversation

t-yoshii
Copy link

@t-yoshii t-yoshii commented Feb 19, 2018

Fixes #803

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

This PR also fixes unit test in SDLStreamingMediaLifecycleManagerSpec.m.

Summary

Currently isHmiStateAudioStreamCapable() in SDLStreamingMediaLifecycleManager.m always return YES. This fix changes this function to return YES only when HMI level is limited or full same as isHmiStateVideoStreamCapable()

Changelog

Bug Fixes
  • Fix to stop audio streaming when HMI level changes to none or background from limited or full.

CLA

@joeljfischer joeljfischer merged commit 6054bf7 into smartdevicelink:develop Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants