Implement SDL 0075 OEM Specific Human Interface Device #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
- test cases for SDLSpatialStruct - test cases for SDLSendHapticData Signed-off-by: NicoleYarroch <[email protected]>
Signed-off-by: NicoleYarroch <[email protected]>
- added send haptic data to function id class and function id spec Signed-off-by: NicoleYarroch <[email protected]>
NicoleYarroch
changed the title
|
@NicoleYarroch Note the conflicts |
|
This will need to be tested against SDL Core contribution after submission before this can be merged. Projected date for the contribution is 8/15. |
Signed-off-by: NicoleYarroch <[email protected]> # Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj
NicoleYarroch
changed the title
|
Update with smartdevicelink/sdl_evolution#234 |
joeljfischer
changed the title
joeljfischer
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #664, #704, #705
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Summary
Implements SDL 0075
This proposal added the RPCs and related tests fro the Send Haptic Data API.
Changelog
Enhancements
SDLSendHapticDataRPC request class and related struct and response.Tasks Remaining:
CLA