Fix an RPCResponseDispatcher crash on clear #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #666
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Will not be unit tested
Summary
This PR changes how the
SDLRPCResponseDispatcherclearmethod works. Currently, before clearing all of its dictionaries, it will run through its list of RPC response handlers and call all existing handlers with an error. We've come across a case where this response handler map could be mutated while being iterated, and this is a crash. To fix this, this PR uses an immutable dictionary copy of the response handler map and iterates over that. This will not be a performance hit becauseclearis not often called, and never in performance intensive situations.Changelog
Bug Fixes
CLA