[SDL 0018] Adding of Nullability Annotations & Removing Dispose Methods #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to fix issue with not being usable in swift.
…ullability_annotations * origin/develop: (30 commits) Remove a test focus Fixed test cases Fix podspec not updated with latest version number Update for v4.5.0 Follow style guide for boolean check Updated formatting of README.md Added steps for using the lock screen manager from SDL's bundle to the readme. Added check when trying to upload an appIcon for a head unit that does not support graphics. Update for v4.5.0 Fixed issue with trying to upload a file that is nil will cause an infinite loop. Fixed an issue with initializer causing infinite loop. Improved readability for nil-checks. Fixed issue relating to SDLLocationDetails' searchAddress using the wrong key for object store. Fixed formatting for some interfaces. Fixed issue with LocationDetails' properties not properly becoming initialized. Fixed issue with waypoints not being correctly initialized as SDLLocationDetails Adding in nil checks for completion handlers of Streaming Media Manager. Updated description to return correct control data name. Update changelog for v4.5.0-beta.1 Update for v4.5.0-beta.1 release ... # Conflicts: # SmartDeviceLink/SDLGetWaypoints.h # SmartDeviceLink/SDLGetWaypoints.m # SmartDeviceLink/SDLGetWaypointsResponse.h # SmartDeviceLink/SDLGetWaypointsResponse.m # SmartDeviceLink/SDLLocationDetails.m # SmartDeviceLink/SDLOnWaypointChange.h # SmartDeviceLink/SDLOnWaypointChange.m # SmartDeviceLink/SDLPerformInteraction.h # SmartDeviceLink/SDLPerformInteraction.m # SmartDeviceLink/SDLShowConstantTBT.h # SmartDeviceLink/SDLShowConstantTBT.m # SmartDeviceLink/SDLSoftButton.h # SmartDeviceLink/SDLSubscribeWaypoints.h # SmartDeviceLink/SDLSubscribeWaypoints.m # SmartDeviceLink/SDLSubscribeWaypointsResponse.h # SmartDeviceLink/SDLUnsubscribeWaypoints.h # SmartDeviceLink/SDLUnsubscribeWaypoints.m # SmartDeviceLink/SDLUnsubscribeWaypointsResponse.h # SmartDeviceLink/SDLUnsubscribeWaypointsResponse.m
…lect nullability changes.
…ullability_annotations * origin/develop: Removed SDLTTSChunkFactory from project. Removed SDLRPCRequestFactory from project. # Conflicts: # SmartDeviceLink/SDLRPCRequestFactory.h # SmartDeviceLink/SDLRPCRequestFactory.m # SmartDeviceLink/SDLTTSChunkFactory.h # SmartDeviceLink/SDLTTSChunkFactory.m
asm09fsu
added
best practice
joeljfischer
approved these changes
Jan 17, 2017
joeljfischer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
Testing is done by viewing the properties of all RPCs as described in the RPC Spec, and making sure they conform to the mandatory value of those items (if missing, mandatory is true).
Summary
Added in nullability checks for all properties and classes in the project. These will give warnings in Objective-C if use improperly, and issues if used incorrectly in Swift. We also removed all dispose methods from the project, as the nullability should handle most of this. Any additional cleanup was moved over to
dealloc.Changelog
Breaking Changes
Enchancements