Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alert operation soft button image to display if no soft button capability is present #2080

Merged

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Apr 6, 2022

Fixes #2079

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Added a unit test for when there's no soft button capability

Core Tests

  • Alerts with soft button images presented (manticore / Sync).
  • Removed soft button capability then presented an alert with a softbutton with an image. Image was presented properly.

Core version / branch / commit hash / module tested against: Manticore (Core 7.1.1), Sync 3.4, Core 8.1.0-develop
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI 0.11.0), Sync 3.4, Generic_HMI 0.12.0-develop

Summary

Updated the PresentAlertOperation to send soft button images when the alert soft button image capability is unknown.

Changelog

Bug Fixes
  • Alert operation soft button images are now on by default if there's no capability

Tasks Remaining:

  • Test against Core with the soft button image capability removed

CLA

* Alert operation soft button images are now on by default if there's no capability
@joeljfischer joeljfischer added bug A defect in the library manager-screen Relating to the manager layer - screen managers labels Apr 6, 2022
@joeljfischer joeljfischer self-assigned this Apr 6, 2022
@joeljfischer joeljfischer marked this pull request as draft April 6, 2022 13:15
@joeljfischer joeljfischer marked this pull request as ready for review April 6, 2022 15:42
@joeljfischer joeljfischer merged commit 4b5b1b8 into develop Apr 8, 2022
@joeljfischer joeljfischer deleted the bugfix/issue-2079-alert-softbutton-images-on-by-default branch April 8, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants