Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If raw data fails to encrypt, don't send the protocol message #2005

Merged

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Jun 1, 2021

Fixes #1830

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

No unit test updates needed

Core Tests

  • Start up an encrypted video stream

Core version / branch / commit hash / module tested against: v7.1.1
HMI name / version / branch / commit hash / module tested against: generic_hmi v0.10.0

Summary

  1. If a packet of video data fails to encrypt, the protocol message wrapper will not be sent.
  2. If a StartService is encrypted, it's payload should be sent.

Changelog

Bug Fixes
  • If a packet of video data fails to encrypt, the protocol message wrapper will not be sent. This should prevent Core from receiving malformed video data.
  • If an encrypted StartService is sent, the payload should be included. This should prevent Core from rejecting video StartService above a certain RPC version level.

Tasks Remaining:

  • Smoke Tests

CLA

@joeljfischer joeljfischer added bug A defect in the library protocol Relating to the protocol layer labels Jun 1, 2021
@joeljfischer joeljfischer self-assigned this Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #2005 (e0c6c86) into develop (e1785f7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2005      +/-   ##
===========================================
- Coverage    86.10%   86.07%   -0.04%     
===========================================
  Files          441      441              
  Lines        22625    22627       +2     
===========================================
- Hits         19482    19476       -6     
- Misses        3143     3151       +8     

@joeljfischer joeljfischer marked this pull request as ready for review June 2, 2021 16:55
@NicoleYarroch NicoleYarroch self-requested a review June 2, 2021 17:21
@joeljfischer joeljfischer merged commit b4da304 into develop Jun 3, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-1830-failed-video-data-error-handling branch June 3, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library protocol Relating to the protocol layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants