SDL 0180 - Fix to support broaden choice cell uniqueness #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use uniqueText instead of text property
FrankElias77
added
proposal
FrankElias77
changed the title
6 tasks
joeljfischer
suggested changes
Jan 12, 2021
Codecov Report
@@ Coverage Diff @@
## develop #1886 +/- ##
===========================================
- Coverage 85.41% 84.98% -0.43%
===========================================
Files 434 428 -6
Lines 22091 21511 -580
===========================================
- Hits 18868 18282 -586
- Misses 3223 3229 +6 |
joeljfischer
suggested changes
Feb 2, 2021
joeljfischer
suggested changes
Feb 4, 2021
| @@ -160,41 +162,39 @@ - (void)setMenuConfiguration:(SDLMenuConfiguration *)menuConfiguration { | |||
| } | |||
|
|
|||
| - (void)setMenuCells:(NSArray<SDLMenuCell *> *)menuCells { | |||
| NSArray<SDLMenuCell *> *cells = menuCells; | |||
There was a problem hiding this comment.
Is this necessary? It doesn't seem to be doing anything.
There was a problem hiding this comment.
I think this needs to be brought up again. I don't think this is doing anything in the current scheme. All references to cells below seem that they can be changed to menuCells.
joeljfischer
suggested changes
Feb 5, 2021
3 tasks
joeljfischer
suggested changes
Feb 10, 2021
joeljfischer
suggested changes
Feb 16, 2021
| @@ -160,41 +162,39 @@ - (void)setMenuConfiguration:(SDLMenuConfiguration *)menuConfiguration { | |||
| } | |||
|
|
|||
| - (void)setMenuCells:(NSArray<SDLMenuCell *> *)menuCells { | |||
| NSArray<SDLMenuCell *> *cells = menuCells; | |||
There was a problem hiding this comment.
I think this needs to be brought up again. I don't think this is doing anything in the current scheme. All references to cells below seem that they can be changed to menuCells.
…eCell-uniqueness # Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj # SmartDeviceLink/private/SDLMenuManager.m # SmartDeviceLink/public/SDLMenuCell.h # SmartDeviceLinkTests/DevAPISpecs/SDLMenuCellSpec.m # SmartDeviceLinkTests/DevAPISpecs/SDLMenuManagerSpec.m
joeljfischer
suggested changes
Feb 19, 2021
* Simplify dynamicHash method * Move the menuCells documentation to the SDLScreenManager.h file * Fix menu manager using instance properties to handle recursive searches, instead passing pointers * Add tests for dynamicHash method * Fix test for duplicate cells
* Choice sets with identical items would sometimes present out of order because they preloaded out of order
NicoleYarroch
suggested changes
Feb 25, 2021
* Add better SDLFile logging
…cate voice commands * Fix some spelling
NicoleYarroch
approved these changes
Feb 26, 2021
…eCell-uniqueness # Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj # SmartDeviceLink/private/SDLMenuManager.m # SmartDeviceLinkTests/DevAPISpecs/SDLChoiceSetManagerSpec.m # SmartDeviceLinkTests/DevAPISpecs/SDLMenuManagerSpec.m
joeljfischer
deleted the
feature/issue-1024-sdl-0180-broaden-choiceCell-uniqueness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit test update to support cells with same title
Core Tests
N/A
Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A
Summary
broadens choice and sub-menu uniqueness to allow PerformInteraction and sub-menu AddCommand primary text to be identical.
Changelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining:
N/a
CLA