0262 New vehicle data SeatOccupancy #1866

yoooriii · 2020-12-05T20:09:22Z

Fixes #1487

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

I have verified that I have not introduced new warnings in this PR
I have run the unit tests with this PR
I have tested this PR against Core and verified behavior

Unit Tests

2 new tests added to test newly introduced structures

SDLSeatOccupancySpec
SDLSeatStatusSpec

Core version / branch / commit hash / module tested against: Core: sdl_0262_new_vehicle_data_seatOccupancy
HMI name / version / branch / commit hash / module tested against: HMI: sdl_0262_new_vehicle_data_seatOccupancy

Summary

Added new vehicle data SeatOccupancy to know if a vehicle seat is occupied and belted.
New structures are:

SDLSeatOccupancy
SDLSeatStatus

Breaking Changes

No breaking changes

CLA

I have signed the CLA

…with the RPC Generator, files fixed manually afterwards.

…ed init method instead of the deprecated one)

… changes

…th develop branch)

…at occupancy and seat status structs

…needed)

codecov · 2020-12-05T20:57:09Z

Codecov Report

Merging #1866 (aa3ae61) into develop (453d47f) will decrease coverage by 0.05%.
The diff coverage is 94.50%.

@@             Coverage Diff             @@
##           develop    #1866      +/-   ##
===========================================
- Coverage    84.75%   84.69%   -0.06%     
===========================================
  Files          422      420       -2     
  Lines        21156    21058      -98     
===========================================
- Hits         17931    17836      -95     
+ Misses        3225     3222       -3

yoooriii · 2020-12-05T21:00:02Z

Hello @atiwari9, could you please review this PR? Thank you.

atiwari9 · 2020-12-06T06:40:56Z

@standa1-ford - Please take note. @yoooriii - Please tag @standa1-ford for sdl_ios reviews.

SmartDeviceLink/private/SDLRPCParameterNames.h

SmartDeviceLink-iOS.xcodeproj/project.pbxproj

SmartDeviceLink/public/SDLVehicleDataType.m

SmartDeviceLink/public/SDLVehicleDataType.h

standa1-ford

Great Work! Approved!

yoooriii · 2021-01-06T12:47:26Z

Hello @NicoleYarroch @jordynmackool. Could you review please?

joeljfischer

You are also missing changes to VehicleDataManager.swift

SmartDeviceLink/public/SDLGetVehicleData.m

SmartDeviceLink/public/SDLGetVehicleDataResponse.m

SmartDeviceLink/public/SDLOnVehicleData.m

SmartDeviceLink/public/SDLSubscribeVehicleData.m

SmartDeviceLink/public/SDLUnsubscribeVehicleData.m

SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLSeatStatusSpec.m

SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLSubscribeVehicleDataResponseSpec.m

SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLUnsubscribeVehicleDataResponseSpec.m

…review Co-authored-by: Joel Fischer <[email protected]>

…review-2 (remove assign self from init: self=[self initWww] to suppress warnings)

yoooriii · 2021-01-15T15:43:51Z

Hello @joeljfischer. I have updated the PR. Could you please confirm it is ok ? Thank you.

Note: I had a few warnings like this: ${}/SDLUnsubscribeVehicleData.m:40:13: Although the value stored to 'self' is used in the enclosing expression, the value is never actually read from 'self' so I had to remove self= assignment from init methods.

FrankElias77

PR Description tags the wrong issue number. (Fixes 0262 New vehicle data SeatOccupancy #1866)
SDLMaxProxyRPCVersion property in SDLGlobals.m should be set to 7.1.0
Warning in Swift example app. function getAllVehicleData implemented a deprecated init

SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLGetVehicleDataSpec.m

SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLSubscribeVehicleDataSpec.m

SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLUnsubscribeVehicleDataSpec.m

SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLUnsubscribeVehicleDataResponseSpec.m

SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLSubscribeVehicleDataResponseSpec.m

joeljfischer · 2021-01-25T13:36:31Z

Also note that there are merge conflicts on this PR

jordynmackool · 2021-01-25T19:26:55Z

@yoooriii please see the review feedback from the Livio team above. Once the comments are addressed please tag @FrankElias77 and he can re-review.

Thanks!

…this, 2 conflicts in SmartDeviceLink-iOS.xcodeproj/project.pbxproj resolved (accepted both A+B)

yoooriii · 2021-01-26T23:19:52Z

PR Description tags the wrong issue number. (Fixes 0262 New vehicle data SeatOccupancy #1866)

SDLMaxProxyRPCVersion property in SDLGlobals.m should be set to 7.1.0

Warning in Swift example app. function getAllVehicleData implemented a deprecated init

All fixed.

yoooriii · 2021-01-26T23:20:41Z

Hello @FrankElias77. I have already fixed the PR. Could you please re-review? Thank you.

yoooriii · 2021-01-26T23:21:49Z

Also note that there are merge conflicts on this PR

'develop' branch merged, conflicts resolved.

FrankElias77

@yoooriii SDLSubscribeVehicleDataSpec is missing one init function can you add it please

…t SDLSubscribeVehicleDataSpec

yoooriii · 2021-01-28T11:00:38Z

Hello @FrankElias77. I have updated the PR, could you please proceed? Thank you.

SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLSubscribeVehicleDataSpec.m

…this. 2 conflicts in SmartDeviceLink-iOS.xcodeproj/project.pbxproj resolved

yoooriii · 2021-02-02T11:13:41Z

Hello @FrankElias77. I have updated the PR and also I merged develop into is so now unit tests work well. Could you please proceed? Thank you.

yoooriii added 8 commits December 4, 2020 22:58

SDL-0262 'New vehicle data SeatOccupancy': add/update files produced …

adab503

…with the RPC Generator, files fixed manually afterwards.

SDL-0262 'New vehicle data SeatOccupancy': fix example app (use updat…

bc04140

…ed init method instead of the deprecated one)

SDL-0262 'New vehicle data SeatOccupancy': minor: restore unnecessary…

289ca1f

… changes

SDL-0262 'New vehicle data SeatOccupancy': fix warnings - 2

656fdaa

SDL-0262 'New vehicle data SeatOccupancy': fix structures (checked wi…

fec4dba

…th develop branch)

SDL-0262 'New vehicle data SeatOccupancy': implement new tests for se…

ff672d2

…at occupancy and seat status structs

SDL-0262 'New vehicle data SeatOccupancy': revert extra changes (not …

70224eb

…needed)

SDL-0262 'New vehicle data SeatOccupancy': fix a couple of fallen tests

aa3ae61

standa1-ford reviewed Dec 6, 2020

View reviewed changes

SmartDeviceLink/private/SDLRPCParameterNames.h Outdated Show resolved Hide resolved

standa1-ford reviewed Dec 15, 2020

View reviewed changes

SmartDeviceLink-iOS.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

standa1-ford reviewed Dec 15, 2020

View reviewed changes

SmartDeviceLink-iOS.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

standa1-ford reviewed Dec 15, 2020

View reviewed changes

SmartDeviceLink/public/SDLVehicleDataType.m Outdated Show resolved Hide resolved

standa1-ford reviewed Dec 15, 2020

View reviewed changes

SmartDeviceLink/public/SDLVehicleDataType.h Outdated Show resolved Hide resolved

standa1-ford approved these changes Dec 15, 2020

View reviewed changes

yoooriii marked this pull request as ready for review December 21, 2020 09:17

SDL-0262 'New vehicle data SeatOccupancy': apply review comments.

0b45111

NicoleYarroch linked an issue Jan 6, 2021 that may be closed by this pull request

[SDL 0262] New vehicle data SeatOccupancy #1487

Closed

NicoleYarroch assigned yoooriii Jan 6, 2021

NicoleYarroch added proposal Accepted SDL Evolution Proposal rpc Relating to the RPC layer labels Jan 6, 2021

joeljfischer suggested changes Jan 14, 2021

View reviewed changes

yoooriii and others added 2 commits January 15, 2021 12:21

[0262] 'new vehicle data SeatOccupancy': Apply suggestions from code …

a9f1520

…review Co-authored-by: Joel Fischer <[email protected]>

[0262] 'new vehicle data SeatOccupancy': Apply suggestions from code …

66ae0d5

…review-2 (remove assign self from init: self=[self initWww] to suppress warnings)

joeljfischer requested a review from FrankElias77 January 19, 2021 20:18

FrankElias77 requested changes Jan 21, 2021

View reviewed changes

yoooriii added 2 commits January 27, 2021 00:36

[0262] 'new vehicle data seatOccupancy': Merge branch 'develop' into …

6794fe2

…this, 2 conflicts in SmartDeviceLink-iOS.xcodeproj/project.pbxproj resolved (accepted both A+B)

[0262] 'new vehicle data seatOccupancy': apply review comments

e334dd6

yoooriii requested a review from FrankElias77 January 26, 2021 23:22

FrankElias77 requested changes Jan 27, 2021

View reviewed changes

[0262] 'new vehicle data seatOccupancy': added a lost init to the tes…

be02d71

…t SDLSubscribeVehicleDataSpec

yoooriii requested review from joeljfischer and FrankElias77 January 28, 2021 10:59

FrankElias77 reviewed Jan 28, 2021

View reviewed changes

SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLSubscribeVehicleDataSpec.m Outdated Show resolved Hide resolved

FrankElias77 reviewed Jan 28, 2021

View reviewed changes

SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLSubscribeVehicleDataSpec.m Outdated Show resolved Hide resolved

yoooriii added 2 commits February 2, 2021 12:56

[0262] 'new vehicle data seatOccupancy': apply code review in tests

a345774

[0262] 'new vehicle data seatOccupancy': Merge branch 'develop' into …

8990646

…this. 2 conflicts in SmartDeviceLink-iOS.xcodeproj/project.pbxproj resolved

yoooriii requested a review from FrankElias77 February 2, 2021 11:11

FrankElias77 approved these changes Feb 2, 2021

View reviewed changes

NicoleYarroch approved these changes Feb 2, 2021

View reviewed changes

NicoleYarroch merged commit b2f40f3 into smartdevicelink:develop Feb 2, 2021

NicoleYarroch mentioned this pull request Feb 2, 2021

[SDL 0262] New vehicle data SeatOccupancy #1487

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0262 New vehicle data SeatOccupancy #1866

0262 New vehicle data SeatOccupancy #1866

yoooriii commented Dec 5, 2020 •

edited

Loading

codecov bot commented Dec 5, 2020 •

edited

Loading

yoooriii commented Dec 5, 2020

atiwari9 commented Dec 6, 2020

standa1-ford left a comment

yoooriii commented Jan 6, 2021

joeljfischer left a comment

yoooriii commented Jan 15, 2021

FrankElias77 left a comment

joeljfischer commented Jan 25, 2021

jordynmackool commented Jan 25, 2021

yoooriii commented Jan 26, 2021

yoooriii commented Jan 26, 2021

yoooriii commented Jan 26, 2021

FrankElias77 left a comment •

edited

Loading

yoooriii commented Jan 28, 2021

yoooriii commented Feb 2, 2021

0262 New vehicle data SeatOccupancy #1866

0262 New vehicle data SeatOccupancy #1866

Conversation

yoooriii commented Dec 5, 2020 • edited Loading

Risk

Testing Plan

Unit Tests

Summary

Breaking Changes

CLA

codecov bot commented Dec 5, 2020 • edited Loading

Codecov Report

yoooriii commented Dec 5, 2020

atiwari9 commented Dec 6, 2020

standa1-ford left a comment

Choose a reason for hiding this comment

yoooriii commented Jan 6, 2021

joeljfischer left a comment

Choose a reason for hiding this comment

yoooriii commented Jan 15, 2021

FrankElias77 left a comment

Choose a reason for hiding this comment

joeljfischer commented Jan 25, 2021

jordynmackool commented Jan 25, 2021

yoooriii commented Jan 26, 2021

yoooriii commented Jan 26, 2021

yoooriii commented Jan 26, 2021

FrankElias77 left a comment • edited Loading

Choose a reason for hiding this comment

yoooriii commented Jan 28, 2021

yoooriii commented Feb 2, 2021

yoooriii commented Dec 5, 2020 •

edited

Loading

codecov bot commented Dec 5, 2020 •

edited

Loading

FrankElias77 left a comment •

edited

Loading