Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate autoCompleteText property in SDLKeyboardProperties #1786

Conversation

FrankElias77
Copy link
Contributor

Fixes #1784

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Changed tests to support newer init function that doesn't support autoCompleteText property.

Core Tests

N/A

Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Deprecated autoCompleteText property in SDLKeyboardProperties

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • Deprecated autoCompleteText property in SDLKeyboardProperties

Tasks Remaining:

N/A

CLA

deprecate autoCompleteText property in SDLKeyboardProperties
@FrankElias77 FrankElias77 marked this pull request as ready for review September 21, 2020 17:37
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1786 into develop will increase coverage by 0.08%.
The diff coverage is 82.35%.

@@             Coverage Diff             @@
##           develop    #1786      +/-   ##
===========================================
+ Coverage    84.62%   84.70%   +0.08%     
===========================================
  Files          418      418              
  Lines        20930    21078     +148     
===========================================
+ Hits         17711    17855     +144     
- Misses        3219     3223       +4     

@joeljfischer joeljfischer added best practice Not a defect but something that should be improved anyway rpc Relating to the RPC layer labels Oct 1, 2020
@NicoleYarroch NicoleYarroch self-requested a review October 9, 2020 15:10
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

SmartDeviceLink/public/SDLKeyboardProperties.h Outdated Show resolved Hide resolved
SmartDeviceLink/public/SDLKeyboardProperties.h Outdated Show resolved Hide resolved
SmartDeviceLink/public/SDLKeyboardProperties.m Outdated Show resolved Hide resolved
SmartDeviceLink/public/SDLKeyboardProperties.m Outdated Show resolved Hide resolved
SmartDeviceLink/public/SDLKeyboardProperties.m Outdated Show resolved Hide resolved
SmartDeviceLink/public/SDLKeyboardProperties.h Outdated Show resolved Hide resolved
SmartDeviceLink/public/SDLKeyboardProperties.h Outdated Show resolved Hide resolved
@FrankElias77 FrankElias77 changed the base branch from master to develop October 16, 2020 14:26
Re-set autoCompleteText property
Remove warnings
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments

Re-add tests for autoCompleteText
@NicoleYarroch NicoleYarroch self-requested a review October 19, 2020 13:12
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tests are missing in SDLKeyboardPropertiesSpec

More tests added
@NicoleYarroch NicoleYarroch self-requested a review October 19, 2020 18:21
@joeljfischer joeljfischer merged commit 1c2a043 into develop Nov 6, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1784-deprecate-autoCompleteText-property-in-SDLKeyboardProperties branch November 6, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway rpc Relating to the RPC layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The autoCompleteText property in SDLKeyboardProperties should be deprecated
3 participants