-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate autoCompleteText property in SDLKeyboardProperties #1786
deprecate autoCompleteText property in SDLKeyboardProperties #1786
Conversation
deprecate autoCompleteText property in SDLKeyboardProperties
Codecov Report
@@ Coverage Diff @@
## develop #1786 +/- ##
===========================================
+ Coverage 84.62% 84.70% +0.08%
===========================================
Files 418 418
Lines 20930 21078 +148
===========================================
+ Hits 17711 17855 +144
- Misses 3219 3223 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLKeyboardPropertiesSpec.m
Outdated
Show resolved
Hide resolved
…ext-property-in-SDLKeyboardProperties
Re-set autoCompleteText property Remove warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments
Re-add tests for autoCompleteText
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tests are missing in SDLKeyboardPropertiesSpec
More tests added
Fixes #1784
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Changed tests to support newer init function that doesn't support autoCompleteText property.
Core Tests
N/A
Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A
Summary
Deprecated autoCompleteText property in SDLKeyboardProperties
Changelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining:
N/A
CLA