Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated parameters from inits created by the RPC spec generator #1754

Merged

Conversation

NicoleYarroch
Copy link
Contributor

@NicoleYarroch NicoleYarroch commented Aug 14, 2020

Fixes #1722

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit tests were run.

Core Tests

The library was not modified. Only the RPC spec generator was modified.

Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A

Summary

  • If a parameter is deprecated it is no longer included in the generated inits for a struct or class.
  • Since the deprecated parameters are not longer included in the generated inits, the generated inits are no longer wrapped with push/pop pragmas to suppress deprecated warnings.

Changelog

Bug Fixes
  • The RPC spec generator now omits deprecated parameters from the class and struct inits.

CLA

@NicoleYarroch NicoleYarroch added bug A defect in the library rpc-spec-generator Relating to the RPC spec generator labels Aug 14, 2020
@NicoleYarroch NicoleYarroch self-assigned this Aug 14, 2020
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #1754 into develop will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1754   +/-   ##
========================================
  Coverage    84.09%   84.09%           
========================================
  Files          408      408           
  Lines        21160    21160           
========================================
  Hits         17794    17794           
  Misses        3366     3366           

@joeljfischer joeljfischer merged commit c34b89e into develop Aug 18, 2020
@joeljfischer joeljfischer deleted the bugfix/issue_1722_rpc_spec_generator_fix_deprecated_inits branch August 18, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library rpc-spec-generator Relating to the RPC spec generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants