Fix HMI status is cleared #1528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhouxin627 I just wanted to let you know that while reviewing this PR I found some other bugs with the secondary transport manager. I am currently investigating fixes for those bugs that might affect this PR so I am holding off on leaving a review on this PR until I've resolved those bugs. |
|
I believe this was all resolved in #1566, can this be closed? |
|
@joeljfischer Yes, I suppose it can be closed. Thank you. |
|
Closing in favor of PR #1551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1471 and #1479
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Covered by Unit tests.
Summary
Reason
#1471 When TestApp is switched to the background, the status is cleared.
・The HMILevel changes to NONE
・VideoStream changes to NOTStreamable.
#1479 After disconnecting TCP, the status is cleared.
・The HMILevel changes to NONE
・VideoStream changes to NOTStreamable.
The root cause of #1471 and #1479 is the same.
Both of them will invoke the stop function of SDLStreamingVideoLifecycleManager, and clear the status. When it's time to revert, it can not revert due to the wrong status.
★audioStream has the same problem.
Solution
Sequence(#1471)
CLA