Implement SDL-0224 Navigation Subscription Buttons #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
changed the title
joeljfischer
changed the title
justingluck93
changed the title
justingluck93
changed the title
NicoleYarroch
suggested changes
Jul 22, 2019
SmartDeviceLink/SDLButtonName.h
Outdated
| /** | ||
| * Represents a Navigate to center button. | ||
| */ | ||
| extern SDLButtonName const SDLButtonNameNavCenter; |
There was a problem hiding this comment.
This should be SDLButtonNameNavCenterLocation to match the name: NAV_CENTER_LOCATION
There was a problem hiding this comment.
The SDLButtonNameNavCenter name still needs to be updated.
SmartDeviceLink/SDLButtonName.h
Outdated
| /** | ||
| * Represents a Zoom in button. | ||
| */ | ||
| extern SDLButtonName const SDLButtonNameZoomIn; |
There was a problem hiding this comment.
SDLButtonNameZoomIn should be SDLButtonNameNavZoomIn
There was a problem hiding this comment.
All the nav buttons should have Nav in the button name.
SmartDeviceLink/SDLButtonName.h
Outdated
| /** | ||
| * Represents a Pan up button | ||
| */ | ||
| extern SDLButtonName const SDLButtonNamePanUP; |
There was a problem hiding this comment.
Fix the case for UP to Up
SmartDeviceLink/SDLButtonName.h
Outdated
| /* | ||
| * Represents a Rotate counterclockwise button | ||
| */ | ||
| extern SDLButtonName const SDLButtonNameRotateCounterClockWise; |
There was a problem hiding this comment.
Fix the case for ClockWise to Clockwise
NicoleYarroch
suggested changes
Jul 23, 2019
SmartDeviceLink/SDLButtonName.h
Outdated
| /** | ||
| * Represents a Navigate to center button. | ||
| */ | ||
| extern SDLButtonName const SDLButtonNameNavCenter; |
There was a problem hiding this comment.
The SDLButtonNameNavCenter name still needs to be updated.
SmartDeviceLink/SDLButtonName.h
Outdated
| /** | ||
| * Represents a Pan down/right button | ||
| */ | ||
| extern SDLButtonName const SDLButtonNamePanDownRight; |
There was a problem hiding this comment.
The button name is missing the Nav
added 2 commits
July 23, 2019 14:09
NicoleYarroch
approved these changes
Jul 24, 2019
joeljfischer
deleted the
feature/issue-1269-Navigation-Subcription-Buttons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269
This PR is ready for review.
Risk
This PR makes minor API changes.
Summary
Adding enum values so navigation apps can subscribe to navigation hard buttons
CLA