Hit test for a single tap now checked on main thread #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
suggested changes
Apr 1, 2019
There was a problem hiding this comment.
Changing the thread a public API is called on can have an effect on the way the API is used (imagine if a consumer of the touch manager callback used dispatch_sync() to the main queue, this change would start crashing their app). Therefore, I believe it may be a major API change. Would changing the call site in the haptic manager to dispatch to the main queue be a better fix here?
checking if single tap hit a view is now done on main thread
NicoleYarroch
changed the title
|
After doing more testing, I realized that only the single tap touch was not being hit tested on the main thread. I added a HAX to perform the hit test on the main thread and then notify the delegate on the background thread. |
joeljfischer
suggested changes
Apr 2, 2019
* fixed documentation
joeljfischer
approved these changes
Apr 3, 2019
joeljfischer
deleted the
bugfix/issue_1207_haptic_input_checked_on_wrong_thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1207
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Test cases for the
SDLTouchManagerwere updated.Summary
Checking if a single tap is inside a
UIViewno longer causes the app to freeze for a few seconds. All checking is now done on the main thread.Changelog
Breaking Changes
Bug Fixes
UIViewno longer causes the app to freeze for a few seconds. All checking is now done on the main thread.CLA