Fix out of range exception and failure to cancel Asynchronous RPC Operation #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@joeljfischer Good to have it in 6.1.0. Thank you in advance |
| } | ||
| }); | ||
|
|
||
| fit(@"should fail correctly", ^{ |
There was a problem hiding this comment.
Remove the focus from this test case.
NicoleYarroch
suggested changes
Sep 19, 2018
NicoleYarroch
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1076
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit tests have been added
Summary
Fix possible crashes in SDLAsynchronousRPCOperation on cancellation of operations.
Changelog
Bug Fixes
CLA