Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around module ListFiles bug #827

Closed
joeljfischer opened this issue Dec 19, 2017 · 1 comment
Closed

Work around module ListFiles bug #827

joeljfischer opened this issue Dec 19, 2017 · 1 comment
Assignees
@joeljfischer
Labels
bug A defect in the library
Milestone
5.2.0

Comments

@joeljfischer
Copy link
Contributor

Bug Report

On previous version of Core, there is a bug that causes ListFiles to include previously uploaded files that no longer exist on the system. smartdevicelink/sdl_core#1393

We should work around this bug in the SDLFileManager. Likely we need a local array of uploaded files. If an ephemeral file is not in the local list but is in the remote list, the overwrite flag should be automatically toggled and the file uploaded.

Reproduction Steps
  1. Connect to an affected version of SDLCore
  2. Upload several ephemeral files
  3. Disconnect and power cycle SDLCore
  4. Reconnect
  5. Send a ListFiles RPC
  6. Upload the same ephemeral files
Expected Behavior

The previously uploaded files are not listed, new uploads succeed.

Observed Behavior

The previously uploaded files are listed, new uploads fail because they "already exist" when they do not.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: n/a
  • Testing Against: Ford TDK, Core v4.3 and below
@joeljfischer joeljfischer added the bug A defect in the library label Dec 19, 2017
@joeljfischer joeljfischer added this to the Future milestone Dec 19, 2017
@joeljfischer joeljfischer mentioned this issue Dec 19, 2017
Closed
@joeljfischer joeljfischer modified the milestones: Future, 5.2.0 Jan 25, 2018
@joeljfischer joeljfischer self-assigned this Jan 29, 2018
joeljfischer added a commit that referenced this issue Jan 29, 2018
@joeljfischer
Fix #827
2cc9168 
* Set overwrite to true on uploading ephemeral files that have not been uploaded during this session
@joeljfischer joeljfischer mentioned this issue Jan 29, 2018
Merged
2 tasks
joeljfischer added a commit that referenced this issue Jan 29, 2018
@joeljfischer
Fix #827
61113a5 
* Add a public method for testing and transparency
* Add tests
NicoleYarroch added a commit that referenced this issue Feb 23, 2018
@NicoleYarroch
Error handling fixes
04f8d97 
- Moved  HAX: #827 from `uploadFiles:` to `uploadFile:`
- Added test cases for HAX #824
- Fixed `uploadArtwork:` so it always calls `uploadFile:`
- Fixed grammer
- Added source for MD5 hash code
- Added custom error for empty data
@NicoleYarroch NicoleYarroch mentioned this issue Feb 23, 2018
Merged
4 tasks
@joeljfischer joeljfischer mentioned this issue Mar 16, 2018
Merged
2 tasks
@joeljfischer joeljfischer reopened this Dec 3, 2020
@joeljfischer
Copy link
Contributor Author

Reopening this because we should add a version check.

@joeljfischer joeljfischer mentioned this issue Dec 7, 2020
Merged
5 tasks
@joeljfischer joeljfischer mentioned this issue Mar 15, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
1 participant
@joeljfischer