Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/0296 possibility to update video streaming capabilities #223

Merged
merged 15 commits into from
Feb 12, 2021
Merged

Feature/0296 possibility to update video streaming capabilities #223

merged 15 commits into from
Feb 12, 2021

Conversation

KhrystynaDubovyk
Copy link
Contributor

@KhrystynaDubovyk KhrystynaDubovyk commented Aug 7, 2020 •
edited by LitvinenkoIra
Loading

Guidelines updates according to the proposal SDL-0296 smartdevicelink/sdl_core#3465

This PR is ready for review.

Summary

Changelog
Structs/index.md - add AppCapability struct, add additionalVideoStreamingCapabilities param
Enums/index.md - add AppCapabilityType

Create
BC.OnAppCapabilityUpdated - index and assets

Update
BC.OnSystemCapabilityUpdated - update index.md; add OnSystemCapabilityUpdated_VIDEO_STREAMING diagram

@LitvinenkoIra
Copy link
Contributor

@atiwari9 please review this PR

atiwari9
atiwari9 approved these changes Aug 19, 2020
View reviewed changes
Copy link

@atiwari9 atiwari9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the PR

@LitvinenkoIra
Copy link
Contributor

@jordynmackool @JackLivio This PR is ready for Livio review. Thank you!

ShobhitAd
ShobhitAd requested changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@ShobhitAd ShobhitAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new entry for OnAppCapabilityUpdated has to be added in config.json

docs/BasicCommunication/OnAppCapabilityUpdated/index.md Outdated Show resolved Hide resolved
docs/BasicCommunication/OnAppCapabilityUpdated/index.md Show resolved Hide resolved
docs/BasicCommunication/OnAppCapabilityUpdated/index.md Show resolved Hide resolved
docs/BasicCommunication/OnSystemCapabilityUpdated/index.md Show resolved Hide resolved
docs/Common/Structs/index.md Outdated Show resolved Hide resolved
@KhrystynaDubovyk
Copy link
Contributor Author

A new entry for OnAppCapabilityUpdated has to be added in config.json

done in 49651e1

@ShobhitAd
Copy link
Contributor

@KhrystynaDubovyk Thank you for making the changes. Could you also please re-generate the sequence diagram docs/BasicCommunication/OnAppCapabilityUpdated/assets/OnAppCapabilityUpdated.png based on the changes from 570f696#diff-2db152cf1a1fa3403ab09f6a4b119c395190c5790055dffe0b20d8662e98a9ef

@KhrystynaDubovyk
Copy link
Contributor Author

@KhrystynaDubovyk Thank you for making the changes. Could you also please re-generate the sequence diagram docs/BasicCommunication/OnAppCapabilityUpdated/assets/OnAppCapabilityUpdated.png based on the changes from 570f696#diff-2db152cf1a1fa3403ab09f6a4b119c395190c5790055dffe0b20d8662e98a9ef

@ShobhitAd, fixed in bea7440

@ShobhitAd
Copy link
Contributor

@KhrystynaDubovyk please resolve merge conflicts on PR

@dboltovskyi
Merge remote-tracking branch 'smart/develop' into feature/0296_possib…
91e3265 
…ility_to_update_video_streaming_capabilities
@ShobhitAd ShobhitAd merged commit fdb7116 into smartdevicelink:develop Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitvinenkoIra LitvinenkoIra LitvinenkoIra left review comments

@atiwari9 atiwari9 atiwari9 approved these changes

@ShobhitAd ShobhitAd ShobhitAd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KhrystynaDubovyk @LitvinenkoIra @ShobhitAd @atiwari9 @dboltovskyi