Fix media indicator icons #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issues is observed while working with multiple media applications registered. Once media indicators are changed for one application, second application shows also changed indicators instead of their own. To resolve that, propery binding was changed to active model which triggers callbacks properly and allows to display the correct seek indicators for each media application.
jacobkeeler
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519
This PR is ready for review.
Testing Plan
Precondition:
"updateMode":"COUNTUP",
"startTime": { "hours":0, "minutes":15, "seconds":30 },
"backSeekIndicator": {"seekTime":30,"type":"TIME" },
"forwardSeekIndicator": { "seekTime":30,"type":"TIME"}
'SEEKLEFT' button with "ico_seek_left.png" image is observed on HMI
'SEEKRIGHT' button with "ico_seek_right.png" image is observed on HMI
Steps to reproduce:
Expected result:
SEEKLEFT' button with "ico_prew.png" image is observed on HMI for App2
'SEEKRIGHT' button with "Ico_next.png" image is observed on HMI for App2
Summary
The issues is observed while working with multiple media applications registered. Once media indicators are changed for one application, second application shows also changed indicators instead of their own.
To resolve that, propery binding was changed to active model which triggers callbacks properly and allows to display the correct seek indicators for each media application.
CLA