Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepted revisions for SDL-0267 Main Menu UI Updates #895

Conversation

joeljfischer
Copy link
Contributor

Updates

  • Moved AddCommand text parameters into MenuParams.
  • Made submenu into subMenu for consistency with the MOBILE_API.

@joeljfischer
Copy link
Contributor Author

@theresalech this is ready for review

Copy link
Contributor

@theresalech theresalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the AddSubmenu references in the descriptions be AddSubMenu as well?

proposals/0267-addcommand-ui-updates.md Outdated Show resolved Hide resolved
proposals/0267-addcommand-ui-updates.md Outdated Show resolved Hide resolved
proposals/0267-addcommand-ui-updates.md Outdated Show resolved Hide resolved
@joeljfischer
Copy link
Contributor Author

@theresalech Yes, thanks for the catch. Everything has been addressed.

@theresalech theresalech merged commit 4191e28 into smartdevicelink:master Dec 17, 2019
@joeljfischer joeljfischer deleted the sdl-0267-main-menu-ui-updates-accepted-revisions branch March 26, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants