Revise SDL-0305 Homogenize TextFieldName #1109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This is a revision to an accepted, but not yet implemented proposal. The suggested revision is to remove the TextFieldName
navigationText
from the HMI_API.xml instead of adding it to the MOBILE_API.xml. As describednavigationText
andturnText
refer to the same text field, andturnText
is the only one of the two that is used in SDL Core, sonavigationText
is redundant and can be removed.Motivation
It has been noticed that
navigationText
is not used by sdl_core or either supported HMI as a TextFieldName.Proposed Solution
The proposed solution is to remove redundant TextFieldName
navigationText
from the project.HMI API Changes
Remove
navigationText
fromTextFieldName
Mobile API Changes
Do not add
navigationText
toTextFieldName
Potential Downsides
The author does not foresee any potential downsides as this TextFieldName is not used.
Impact On Existing Code
Some additional changes would be required to remove
navigationText
from HMI capabilities.