Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted with Revisions] SDL 0289 - Support for Set Language Separately #963

Closed
theresalech opened this issue Mar 11, 2020 · 5 comments
Closed

Comments

@theresalech
Copy link
Contributor

Hello SDL community,

The review of "SDL 0289 - Support for Set Language Separately" begins now and runs through March 17, 2020. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0289-set-language-separately.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#963

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
[email protected]

@joeljfischer
Copy link
Contributor

  1. Even though the JavaScript_Suite has not yet implemented this feature, I believe that is an affected platform.

@zhouxin627
Copy link
Contributor

Hi @joeljfischer ,
Thank you for your opinion. I will add JavaScript_Suite to the Impacted Platforms

@theresalech theresalech changed the title [In Review] SDL 0289 - Support for Set Language Separately [Accepted with Revisions] SDL 0289 - Support for Set Language Separately Mar 18, 2020
@theresalech
Copy link
Contributor Author

The Steering Committee voted to accept this proposal with the following revision: add "JavaScript Suite" to the Impacted Platforms section.

@theresalech
Copy link
Contributor Author

@zhouxin627 please advise when a new PR has been entered to update the proposal to reflect the agreed upon revisions. I'll then merge the PR so the proposal is up to date, and enter issues in respective repositories for implementation. Thanks!

@smartdevicelink smartdevicelink locked as resolved and limited conversation to collaborators Mar 18, 2020
@theresalech
Copy link
Contributor Author

Author has revised proposal to reflect agreed upon revisions and implementation issues have been entered:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants