Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted with Revisions] SDL 0099 Revisions - Revise SDL-0099 - New remote control modules #570

Closed
theresalech opened this issue Aug 1, 2018 · 5 comments

Comments

@theresalech
Copy link
Contributor

theresalech commented Aug 1, 2018

Hello SDL community,

The review of "Revise SDL-0099 - New remote control modules" begins now and runs through August 7, 2018. This will be a review of proposed revisions to a previously accepted but not yet implemented proposal, SDL 0099.

The pull request outlining the revisions under review is available here:

#572

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#570

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
[email protected]

@theresalech theresalech changed the title [In Review] SDL 0099 Revisions - Revise SDL-0099 - New remote control modules [Accepted with Revisions] SDL 0099 Revisions - Revise SDL-0099 - New remote control modules Aug 8, 2018
@theresalech
Copy link
Contributor Author

The Steering Committee voted to accept this proposal in addition to this related and referenced proposal to revise SDL 0175 to explicitly state the GPSdata parameters have become optional.

@theresalech
Copy link
Contributor Author

theresalech commented Aug 8, 2018

@joeljfischer please advise when proposal has been updated to reflect agreed upon revisions.

@smartdevicelink smartdevicelink locked and limited conversation to collaborators Aug 8, 2018
@joeljfischer
Copy link
Contributor

@theresalech @joeygrover I'm uncertain what revisions you wish to see to this pull request. Do you want me to replicate the changes in #577 in my own PR?

@theresalech
Copy link
Contributor Author

@joeljfischer sorry for the confusion. This PR and #577 were both approved by the Steering Committee, so nothing more is needed here. I'll move forward with merging both and updating respective issues.

@theresalech
Copy link
Contributor Author

Issues have been updated accordingly:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants